1809762 - [wpt-sync] Sync PR 37895 - WIP: Add FormData.constructor submitter tests

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 37895 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/37895
Details from upstream follow.

Jon Jensen <[e-mail]> wrote:

WIP: Add FormData.constructor submitter tests

Comment 1

[Jon Jensen]

Attachment: WIP: Bug 1809762 - WIP: Add optional submitter argument to FormData constructor

Note that this has not been accepted yet, this is just a POC
Context: https://github.com/whatwg/xhr/pull/366

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=87d9e839d06fb87ebcd51cb8d96c15f82662f8db

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 7 subtests

Status Summary

Firefox

OK : 1
PASS: 2
FAIL: 5

Chrome

OK : 1
PASS: 2
FAIL: 5

Safari

OK : 1
PASS: 2
FAIL: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /xhr/formdata/constructor-submitter.html [wpt.fyi]
  • FormData construction should throw a TypeError if a non-null submitter is not a submit button: FAIL (Chrome: FAIL, Safari: FAIL)
  • FormData construction should throw a 'NotFoundError' DOMException if a non-null submitter is not owned by the form: FAIL (Chrome: FAIL, Safari: FAIL)
  • The constructed FormData object should contain an in-tree-order entry for a named submit button submitter: FAIL (Chrome: FAIL, Safari: FAIL)
  • The constructed FormData object should contain in-tree-order entries for an activated Image Button submitter: FAIL (Chrome: FAIL, Safari: FAIL)
  • The constructed FormData object should contain in-tree-order entries for an unactivated Image Button submitter: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Phabricator Automation]

Comment on attachment 9313613 [details]
WIP: Bug 1809762 - WIP: Add optional submitter argument to FormData constructor

Revision D167576 was moved to bug 1812696. Setting attachment 9313613 [details] to obsolete.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fecb4a90a600
[wpt PR 37895] - Add FormData.constructor submitter tests, a=testonly
https://hg.mozilla.org/integration/autoland/rev/3b3cd899fddd
[wpt PR 37895] - Update wpt metadata, a=testonly

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/fecb4a90a600
https://hg.mozilla.org/mozilla-central/rev/3b3cd899fddd