Remove unused fields of TargetMixin
Categories
(DevTools :: General, task)
Tracking
(firefox111 fixed)
| Tracking | Status | |
|---|---|---|
| firefox111 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 1 open bug, Regressed 1 open bug)
Details
Attachments
(4 files)
A few attributes are no longer used on TargetMixin and some others could be dropped in favor of alternatives.
|
Assignee | |
Comment 1•1 year ago
|
||
They should rather be queried on the descriptor front.
|
||
Updated•1 year ago
|
|
|
Assignee | |
Comment 2•1 year ago
|
||
Legacy addon should no longer exist. We only support WebExtensions (at least in DevTools).
|
|
Assignee | |
Comment 3•1 year ago
|
||
Ideally, the debugging context should rather be defined by the descriptor
rather than the top target.
On top of that isAddon is only an alias for isWebExtension.
So drop most usages of isAddon and otherwise use isWebExtension.
|
|
Assignee | |
Comment 4•1 year ago
|
||
This is a very old and legacy attribute which always had a fuzzy definition.
As of today it was a somewhat alias of "not debugging a local/remote tab".
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cdd531783324 [devtools] Remove TargetMixin.isLocalTab/localTab attributes. r=devtools-reviewers,nchevobbe https://hg.mozilla.org/integration/autoland/rev/9bb5167ebc4b [devtools] Remove a few unused attributes of TargetMixin. r=devtools-reviewers,nchevobbe https://hg.mozilla.org/integration/autoland/rev/92d5cc5ee69e [devtools] Remove TargetMixin.isAddon. r=devtools-reviewers,nchevobbe https://hg.mozilla.org/integration/autoland/rev/14b861cccbeb [devtools] Remove TargetMixin.chrome attribute. r=devtools-reviewers,nchevobbe
|
||
Comment 6•1 year ago
|
||
Backed out 4 changesets (Bug 1809848) for causing damp failures on browser-toolbox.js.
Backout link
Push with failures <--> dump-other
Failure Log
|
|
Assignee | |
Comment 7•1 year ago
|
||
I missed an occurence of chrome in toolbox-options.
New try run focusing on damp:
https://treeherder.mozilla.org/jobs?repo=try&revision=e478f1da7ade6e1a1fcbf6648c165e33fd093176
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/05e57c08310f [devtools] Remove TargetMixin.isLocalTab/localTab attributes. r=devtools-reviewers,nchevobbe https://hg.mozilla.org/integration/autoland/rev/17b823d1492e [devtools] Remove a few unused attributes of TargetMixin. r=devtools-reviewers,nchevobbe https://hg.mozilla.org/integration/autoland/rev/78375e26bffe [devtools] Remove TargetMixin.isAddon. r=devtools-reviewers,nchevobbe https://hg.mozilla.org/integration/autoland/rev/7dfd8676b3c7 [devtools] Remove TargetMixin.chrome attribute. r=devtools-reviewers,nchevobbe
|
||
Comment 9•1 year ago
|
||
Backed out for causing failures at browser_toolbox_options_disable_js.
Backout link: https://hg.mozilla.org/integration/autoland/rev/132e327cd1236fcf9de4d39ac53574e1ab527d7b
Failure log: https://treeherder.mozilla.org/logviewer?job_id=402677008&repo=autoland&lineNumber=7318
|
||
Comment 10•1 year ago
|
||
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c25fa11188b5 [devtools] Remove TargetMixin.isLocalTab/localTab attributes. r=devtools-reviewers,nchevobbe https://hg.mozilla.org/integration/autoland/rev/d110dad28838 [devtools] Remove a few unused attributes of TargetMixin. r=devtools-reviewers,nchevobbe https://hg.mozilla.org/integration/autoland/rev/9c47abfb1d07 [devtools] Remove TargetMixin.isAddon. r=devtools-reviewers,nchevobbe https://hg.mozilla.org/integration/autoland/rev/45747743e2e2 [devtools] Remove TargetMixin.chrome attribute. r=devtools-reviewers,nchevobbe
|
||
Comment 11•1 year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c25fa11188b5
https://hg.mozilla.org/mozilla-central/rev/d110dad28838
https://hg.mozilla.org/mozilla-central/rev/9c47abfb1d07
https://hg.mozilla.org/mozilla-central/rev/45747743e2e2
|
|
Assignee | |
Updated•1 year ago
|
Description
•