Closed Bug 1809866 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 37901 - Revert "Initialize long task reporting for ScriptPromiseResolver"

Categories

(Core :: DOM: Performance, task, P4)

task

Tracking

()

RESOLVED FIXED
111 Branch
Tracking Status
firefox111 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 37901 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/37901
Details from upstream follow.

Rune Lillesveen <futhark@chromium.org> wrote:

Revert "Initialize long task reporting for ScriptPromiseResolver"

This reverts commit 7943977c5d425843c086abe84c326b7fb4145838.

Reason for revert: Possible culprit for failing longtask-timing tests

See: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110615/overview

Original change's description:

Initialize long task reporting for ScriptPromiseResolver

This tells the PerformanceMonitor to report longtasks
in promise chains that were not started from a callback,
e.g. fetch().then(() => {...long_task})

The PerformanceMonitor relies on different probes for "attribution": connecting a long task with one or more frames, to avoid reporting a long task to an unrelated frame tree that happens to be on the same thread.

This design is a bit brittle, as we need to patch through all the things that can invoke a frame-attributed task into PerformanceMonitor.

This CL doesn't attempt to solve this brittleness, in lack of a better solution, but rather to mitigate the particular issue with tasks invoked with a promise, by patching through ScriptPromiseResolver to PerformanceMonitor.

Bug: 1251964
Change-Id: I745780f834f9d1dfc8e8a5c8295326f06276cba6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4129480
Commit-Queue: Noam Rosenthal \<nrosenthal@chromium.org>
Reviewed-by: Jeremy Roman \<jbroman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1091706}

Bug: 1251964
Change-Id: I2841851f39739cdcc65ca8044115173f97cd88da
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4161792
Owners-Override: Rune Lillesveen \<futhark@chromium.org>
Commit-Queue: Rubber Stamper \<rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Rune Lillesveen \<futhark@chromium.org>
Auto-Submit: Rune Lillesveen \<futhark@chromium.org>
Bot-Commit: Rubber Stamper \<rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1091761}

PR 37901 applied with additional changes from upstream: 561844498cd6773a5822757cfa9d1ee3196b94d3
Component: web-platform-tests → DOM: Performance
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 12 tests and 1 subtests

Status Summary

Firefox

OK : 10
FAIL : 13
ERROR: 2

Chrome

OK : 12
PASS : 15

Safari

OK : 10
FAIL : 13
ERROR: 2

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0f1e72bfea65
[wpt PR 37901] - Revert "Initialize long task reporting for ScriptPromiseResolver", a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in before you can comment on or make changes to this bug.