1809868 - [wpt-sync] Sync PR 37902 - Include shadow offsets when clipping fragmented shadows.

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 37902 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/37902
Details from upstream follow.

Morten Stenshorne <[e-mail]> wrote:

Include shadow offsets when clipping fragmented shadows.

Box shadows were sometimes missing when fragmented, because we didn't
handle shadow offsets (the first two length values in 'box-shadow')
correctly. It worked fine-ish in many cases when blur was involved,
though, due to the fuzz by which we expand the clip rectangles in such
cases.

Bug: 1402736
Change-Id: Ife8a5ea00cc7492068ae90c21f322e76496a8ce8
Reviewed-on: https://chromium-review.googlesource.com/4161432
WPT-Export-Revision: f84ddd764f0ab40aa49fd396a83527c0bc0b0a88

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=30630e81695232dca26c6c68e51cb96d82f787dc

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests

Status Summary

Firefox

FAIL: 6

Chrome

FAIL: 6

Safari

PASS: 1
FAIL: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-backgrounds/box-shadow/slice-block-fragmentation-001.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-backgrounds/box-shadow/slice-block-fragmentation-002.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-backgrounds/box-shadow/slice-block-fragmentation-003.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: PASS)
• /css/css-backgrounds/box-shadow/slice-inline-fragmentation-001.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-backgrounds/box-shadow/slice-inline-fragmentation-002.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-backgrounds/box-shadow/slice-inline-fragmentation-003.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e10aee086d0
[wpt PR 37902] - Include shadow offsets when clipping fragmented shadows., a=testonly
https://hg.mozilla.org/integration/autoland/rev/bbcc97fef090
[wpt PR 37902] - Update wpt metadata, a=testonly

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/6e10aee086d0
https://hg.mozilla.org/mozilla-central/rev/bbcc97fef090