1810024 - Focus on AB toolbar buttons has no visual indication - Creating a new address book or mailing list via keyboard undiscoverable in the new AB

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Thomas D. (:thomas8)]

+++ This bug was initially created as a clone of Bug #1751282 +++

Richard, this seems to be a Theme issue, can you have a look?

TB 102.6.1 (64-bit), Win10

Again - no discoverable keyboard way of creating a new custom address book or mailing list in the NEW address book - Bug 1751282 landed on 102, but regressed.

Bug 1751282 implemented tab stops on each of the AB toolbar buttons (New Address Book, New Contact, New List, Import).

STR

• Select an address book in directory pane
• Press Shift+Tab exactly twice
• Press Enter

Actual

• New Mailing List dialog pops up (OK)
• So the tab stops are still there, but there's no visual indication of the focused button on the AB toolbar, so this is no-op (this bug). Seems to be a theme issue.

Expected

• Focused button on the AB toolbar needs focus indication (blue border)

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1810024-ab-focus.patch

The variable --in-content-focus-outline was added in 104 and not uplifted to ESR Using --focus-outline.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9312141 [details] [diff] [review]
1810024-ab-focus.patch

Review of attachment 9312141 [details] [diff] [review]:
-----------------------------------------------------------------

Usually I would be against doing a direct 102 uplift without passing through c-c and beta, but this is a very minor CSS issue, therefore is acceptable.
Thanks for the fix.

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 9312141 [details] [diff] [review]
1810024-ab-focus.patch

[Approval Request Comment]
User impact if declined: no focus ring on AB toolbar buttons
Testing completed (on c-c, etc.): this is a ESR only bug
Risk to taking this patch (and alternatives if risky): low

Comment 4

[Richard Marti (:Paenglab)]

I'll close this bug to get the correct state for the check-in to ESR (I hope).

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9312141 [details] [diff] [review]
1810024-ab-focus.patch

[Triage Comment]
Approved for esr102

Comment 6

[Daniel Darnell [:dandarnell]]

Thunderbird 102.7.1:
https://hg.mozilla.org/releases/comm-esr102/rev/33686ccbfe50