1810095 - Remove now-unused old storage actor and split the file per storage type

Status: RESOLVED FIXED

(DevTools :: Storage Inspector, task)

Description

[Alexandre Poirot [:ochameau]]

Thanks to bug 1578975 and previous bugs in that queue, the old Storage Actor, only exposing "listStores" is no longer used anywhere.
We can drop it, while keeping the per-storage-type code.
We can then move these per-storage-type code closer to their related resource watchers.
We have one watcher per storage type. When doing that, we can finally split this huge storage.js file.

Then, we may followup and try to merge these files into each watcher module.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1810095 - [devtools] Remove now-unused Storage target scoped actor.

This actor was only used by the legacy listener.
Its main method was listStores which exposed all the storage type actors.
Now they are exposed via storage Resource watchers.

This requires to tweak the decision making to show the storage panel
as the actor no longer exists... Unfortunately we can't check for
resource traits on the watcher actor as the browser toolbox
on older runtime won't expose it.

Note that this.front wasn't used for a little while in ui.js.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1810095 - [devtools] Split storage actor file into one file per storage type.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1810095 - [devtools] Split storage actor file into one file per storage type.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1810095 - [devtools] Fix extension storage updates when the add-on is reloaded.

I actually regressed this from D166661 within this current patch queue.
It isn't clear why the old code was somehow keeping the parent/ext-storage.js class
alive -or- somehow magically recalling apiManager.asyncGetAPI after addon reload.
But now we handle the case of addon reload explicitly.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87928fc48338
[devtools] Remove now-unused Storage target scoped actor. r=devtools-reviewers,devtools-backward-compat-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/c7a52c3d61c7
[devtools] Split storage actor file into one file per storage type. r=devtools-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/75d62a6784c2
[devtools] Fix extension storage updates when the add-on is reloaded. r=devtools-reviewers,rpl,jdescottes

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/87928fc48338
https://hg.mozilla.org/mozilla-central/rev/c7a52c3d61c7
https://hg.mozilla.org/mozilla-central/rev/75d62a6784c2