181016 - selfserv doesn't run on OS/2

Status: RESOLVED INVALID

(NSS :: Tools, defect, P3)

Description

[Julien Pierre]

When building NSS standalone, the SSL server selfserv runs but fails in
PR_SetFDInheritable. This function is not supported on OS/2.

Comment 1

[Julien Pierre]

Attachment: don't call PR_SetFDInheritable on OS/2

Comment 2

[Mike Kaply [:mkaply]]

Shouldn't we just make PR_SetFDInheritable return success so code doesn't have
to change?

If it is not really needed?

Comment 3

[Julien Pierre]

No, this is usually done for a good reason - security. Those sockets really
shouldn't be accessible to the child processes. In a web server for example that
would mean a CGI program could "steal" connections from the main daemon. This
disalbing is only OK to do it in the example server program because it isn't a
real server program, I only use it for performance testing. But serious
applications might be calling the function and tricked into thinking that it
works. We don't want to happen.

Incidently, perhaps there is actually way to enable/disable the sharing of the
sockets on OS/2 ? I don't know how, but if you know anyone who worked on TCP/IP
for OS/2, it's worth asking.

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

Seems like this is really a bug against NSPR on OS/2.  
NSS code is doing the correct thing.  
I'm inclined to mark this invalid.  Objections?

Comment 5

[Mike Kaply [:mkaply]]

The bug is that PR_SetFDInheritable doesn't work. We don't need two bugs.

Comment 6

[Wan-Teh Chang]

You can also make selfserv do something sensible if
PR_SetFDInheritable fails with PR_NOT_IMPLEMENTED_ERROR.
But I have no problem with marking this bug invalid or
WONTFIX.