1810214 - Extract WebSiteBreachAlertPanel

Status: RESOLVED FIXED

(Firefox :: about:logins, task, P2)

Comment 1

[Sergey Galich [:serg]]

Attachment: image.png

Comment 2

[Micah [:mtigley] (she/her)]

Attachment: WIP: Bug 1810214 - Extract breached/vulnerable alert panel to single component.

Comment 3

[Issam Mani [:issammani]]

Requirements

• Reuse existing message-bar component if possible
• An l10n string translating to “Website Breach”
• An icon displayed next to title
• A message containing the date the breach occurred
• Information about the breach, including a link to the origin.

Interactivity

• Hyperlinks that navigate user to website

Styling

• Follows design guidelines from message-bar component
• Use the “error” style

Comment 4

[Issam Mani [:issammani]]

Attachment: Bug 1810214 - P1. Add base element for login alerts. r=#credential-management-reviewers!

Comment 5

[Issam Mani [:issammani]]

Attachment: Bug 1810214 - P2. Add website breach alert element. r=#credential-management-reviewers!

Depends on D178793

Comment 6

[Issam Mani [:issammani]]

Attachment: Bug 1810214 - P3. Add alert element stories. r=#credential-management-reviewers!

Depends on D178794

Comment 7

[Issam Mani [:issammani]]

Attachment: Bug 1810214 - P4. Move styles to external css file. r=#credential-management-reviewers!

Depends on D178795

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54fab76ec896
P1. Add base element for login alerts. r=credential-management-reviewers,mtigley
https://hg.mozilla.org/integration/autoland/rev/53374556c51b
P2. Add website breach alert element. r=credential-management-reviewers,mtigley
https://hg.mozilla.org/integration/autoland/rev/034373b00451
P3. Add alert element stories. r=credential-management-reviewers,mtigley
https://hg.mozilla.org/integration/autoland/rev/984027ab6966
P4. Move styles to external css file. r=credential-management-reviewers,mtigley,desktop-theme-reviewers,dao

Comment 9

[Cristina Horotan [:chorotan]]

Backed out 4 changesets (bug 1810214) for causing bc failures on browser_all_files_referenced.js

Backout: https://hg.mozilla.org/integration/autoland/rev/f01ee732a29345fe5d2f0fdcd54a0c7e687bf130

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=984027ab69668b0fd5d663c35c238471da399761

Failure log: https://treeherder.mozilla.org/logviewer?job_id=418618642&repo=autoland&lineNumber=3144

Comment 10

[Issam Mani [:issammani]]

Hmm it seems we don't have proper tree shaking but instead have a test fail when a resource is unused. I will update my patch and land again. Thanks !

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/569c0f68e8a1
P1. Add base element for login alerts. r=credential-management-reviewers,mtigley
https://hg.mozilla.org/integration/autoland/rev/018f7a49e271
P2. Add website breach alert element. r=credential-management-reviewers,mtigley
https://hg.mozilla.org/integration/autoland/rev/0ac0ed266289
P3. Add alert element stories. r=credential-management-reviewers,mtigley
https://hg.mozilla.org/integration/autoland/rev/c7b3905a77fb
P4. Move styles to external css file. r=credential-management-reviewers,mtigley,desktop-theme-reviewers,dao

Comment 12

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/569c0f68e8a1
https://hg.mozilla.org/mozilla-central/rev/018f7a49e271
https://hg.mozilla.org/mozilla-central/rev/0ac0ed266289
https://hg.mozilla.org/mozilla-central/rev/c7b3905a77fb