181023 - Make flag descriptions visible to bugzilla users

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, enhancement)

Description

[Asa Dotzler [:asa]]

We currently have descriptions in the management interface for flags. It would
be really good if this was made visible in the bug. Several mechanisms for
making this visible are:
1. mouse over the flag in show_bug and see a description in a tooltip (title
attribute). 
2. like activestate's bugzilla, put a little information "i" icon next to the
flag which when clicked makes a popup window with a description of that flag. 
3. create something like describekeywords but for flags. 

1 & 2 appeal a lot more to me than 3 but 3 might be easiest. The reason I like 1
and 2 is that flags can be product and component specific and there may be
similarly named flags with different description so attaching a description to
the speficif flag the users is looking at is more appealing than a big flat list
with all flags.

Comment 1

[timeless]

Attachment: draft

Comment 2

[Colin Ogilvie [:cso]]

Attachment: draft 2

Draft 2 - fixes a minor issue with Timely's patch

Comment 3

[Asa Dotzler [:asa]]

Just a quick note, I do not want this enabled at b.m.o. until I've had a chance
to clean up the descriptions. 

Comment 4

[Colin Ogilvie [:cso]]

Attachment: Patch v1

Patch v1

This merges all the draft comments, and fixes a couple of minor bugs in them.

Comment 5

[Frédéric Buclin]

Comment on attachment 178682 [details] [diff] [review]
Patch v1

>     # Get a list of request type names to use in the filter form.
>-    my @types = ("all");
>-    SendSQL("SELECT DISTINCT(name) FROM flagtypes ORDER BY name");
>-    push(@types, FetchOneColumn()) while MoreSQLData();
>+    my %types;
>+    $types{'all'} = { description => '' };
>+    SendSQL("SELECT DISTINCT(name), description FROM flagtypes ORDER BY name");
>+    while (MoreSQLData()) {
>+        my ($name, $description) = FetchSQLData();
>+        $types{$name} = { description => $description};
>+    }

flag type names are not unique. Doing so, all flag types with the same name
will have the same description. Of course, this is wrong. Moreover, please use
the new DBI stuff instead of the old SendSQL/MoreSQLData one.

Comment 6

[Rob Siklos [:robzilla]]

Attachment: robzilla_v1

This shows the flag description in a tooltip.

Comment 7

[Frédéric Buclin]

*** Bug 296072 has been marked as a duplicate of this bug. ***

Comment 8

[Frédéric Buclin]

Comment on attachment 184939 [details] [diff] [review]
robzilla_v1

>         <td>
>-          [% type.name FILTER html FILTER no_break %]
>+          <label title="[% type.description FILTER html %]">
>+            [%- type.name FILTER html FILTER no_break %]</label>
>         </td>

Nice patch. But it would be fine to have tooltips even when hovering the
dropdown menu. It seems possible to do it by adding a title="" to the select
element. Moreover, you missed the multiplicable flags around line 180.

Comment 9

[Rob Siklos [:robzilla]]

Attachment: robzilla_v2

Comment 10

[Frédéric Buclin]

Comment on attachment 185010 [details] [diff] [review]
robzilla_v2

nice patch. r=LpSolit

Comment 11

[Frédéric Buclin]

Checking in template/en/default/flag/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/flag/list.html.tmpl,v 
<--  list.html.tmpl
new revision: 1.18; previous revision: 1.17
done

Comment 12

[Dave Miller [:justdave]]

*** Bug 304592 has been marked as a duplicate of this bug. ***

Comment 13

[Colin Ogilvie [:cso]]

*** Bug 325266 has been marked as a duplicate of this bug. ***

Comment 14

[Max Kanat-Alexander]

Added to the Bugzilla 2.22 Release Notes in bug 322960.