1810250 - Add weather icons for weather suggestions

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Comment 1

[Mandy Cheang [:mcheang][she/her]]

Attachment: Bug 1810250 - Add weather icons for weather suggestions in the urlbar.r=adw

This patch receives a weather icon id from our merino server. We then use that
icon id and map it to a specific weather icon svg file within
urlbar-dyanmic-result.css.

Comment 2

[Mandy Cheang [:mcheang][she/her]]

Attachment: Bug 1810250 - Add weather icons for weather suggestions in the urlbar.r=adw

This patch receives a weather icon id from our merino server. We then use that
icon id and map it to a specific weather icon svg file within
urlbar-dyanmic-result.css.

Comment 3

[Mandy Cheang [:mcheang][she/her]]

Comment on attachment 9312285 [details]
Bug 1810250 - Add weather icons for weather suggestions in the urlbar.r=adw

Beta/Release Uplift Approval Request

• User impact if declined: We want to get the icons out to beta users for weather suggestions in the urlbar for foxfooding in beta. If this patch is declined, the user will see a star placeholder for the weather icon and not the actual weather icon, such as rainy, sunny, snowy, etc.

This code is not covered by automated test because it only contains changes for ui styling by adding svg files. There is already existing code for weather suggestions in place else where.

• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch is not risky because it only invovles UI updates by adding the weather icon svg files. There's no potential for this patch to block the functioning of the urlbar.
• String changes made/needed: N/A
• Is Android affected?: No

Comment 4

[Mandy Cheang [:mcheang][she/her]]

[Tracking Requested - why for this release]:

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dfce1bce524c
Add weather icons for weather suggestions in the urlbar.r=adw,desktop-theme-reviewers,dao DONTBUILD

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing xpc failures in browser/components/urlbar/tests/quicksuggest/unit/test_weather.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/1a781d5323e70acfa7ab152fb2a8cb9e554b1800

Push with failures

Failure log: TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/quicksuggest/unit/test_weather.js | disableAndEnable_featureGate - [disableAndEnable_featureGate : 1] result.payload at result index 0

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9312285 [details]
Bug 1810250 - Add weather icons for weather suggestions in the urlbar.r=adw

Not approving for beta as it was backed out on mozilla-central.

Comment 8

[Mandy Cheang [:mcheang][she/her]]

Thanks for backing it out. I've identified the failure and I am fixing it currently.

Comment 9

[Mandy Cheang [:mcheang][she/her]]

Okay I've updated my patch with the fix.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25e2cd2ef53f
Add weather icons for weather suggestions in the urlbar.r=adw,desktop-theme-reviewers,dao

Comment 11

[Mandy Cheang [:mcheang][she/her]]

Comment on attachment 9312285 [details]
Bug 1810250 - Add weather icons for weather suggestions in the urlbar.r=adw

I fixed the test failure for test_weather.js and pushed to TRY: https://treeherder.mozilla.org/jobs?repo=try&revision=e3d27beb84d439a1ae21740c1ad99b58dc692b8f&selectedTaskRun=aSFmhvY_RGqunDdlLS_p_Q.0

After investigating, the other tests seem unrelated to this patch.
Re-requesting beta uplift.

Comment 12

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/25e2cd2ef53f

Comment 13

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9312285 [details]
Bug 1810250 - Add weather icons for weather suggestions in the urlbar.r=adw

Approved for 110 beta 3, thanks

Comment 14

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/e62fe8d903d1

Comment 15

[Carmen Fat [:cfat] - Ecosystem QA]

I have verified this issue on Firefox Release 111.0.1 (Build ID: 20230321111920) on Firefox Beta 112.0b9 (Build ID: 20230330182947) and the latest Nightly 113.0a1 (Build ID: 20230402214746) on Windows 10 x64, macOS 12.4 and Linux Ubuntu 20.04 x64.

• An icon is displayed each time a weather result is triggered.
• The icon is specific to the described forecast in the weather result.