1810357 - Add HTTP target routes

Status: RESOLVED FIXED

(Remote Protocol :: CDP, enhancement, P5)

Description

[Oliver Medhurst [:canadahonk]]

Steps to reproduce:

Add HTTP target routes like /json/new into the CDP implementation. Relevant CDP docs: https://chromedevtools.github.io/devtools-protocol/#get-jsonnewurl

(Happy to work on this myself.)

Actual results:

Currently they just return 404s as they aren't implemented.

Expected results:

Handle the requests to the target routes instead of 404.

Comment 1

[Oliver Medhurst [:canadahonk]]

Attachment: Bug 1810357 - [cdp] Add HTTP target routes

Added support for /json/new, /json/activate/{targetId},
/json/close/{targetId}. Rewrote JSONHandler internals to support
different routes by HTTP method, and prefixed routes which are required
by activate and close due to inlining the targetId into the request url.

This is a work-in-progress as tests are yet to be added, and it might be
better to depend upon already open D166873 to avoid merge conflicts.
Passes linting but looking for code feedback, apologies for any troubles
by major internal changes.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d125ec07af0b
[cdp] Add HTTP target routes r=webdriver-reviewers,whimboo

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/d125ec07af0b