1810508 - Broken Build when compiling with MSVS 2022

Status: RESOLVED FIXED

(NSS :: Build, defect, P3)

Description

[Dennis Jackson]

Attachment: failure logs for x86-windows.zip

As reported by Burak Arslan:

The coreconf/msvc.sh that ships with NSS 3.87 doesn't work with MSVS 2022.

The full build logs are attached (but are admittedly not too useful). There's one type of error, here's a sample:

D:\buildtrees\nss\x86-windows-dbg\nss\lib\util\secport.c(37): fatal error C1083: Cannot open include file: 'wtypes.h': No such file or directory

wtypes.h is there of course, just cl.exe can't find it. investigation showed that its list of include folders is incomplete and doesn't contain the folder of wtypes.h (among other ones, I imagine).

The workaround is to prevent msvc.sh from doing any damage by setting the environment variables VSPATH, GYP_MSVS_OVERRIDE_PATH and GYP_MSVS_VERSION before running the build script inside a msvc dev shell.

Also, no gyp-next release contains support for MSVS 2022 so I had to use the latest git checkout instead of a stable version.

The full nss 3.87 build script can be found here: https://github.com/microsoft/vcpkg/pull/28933

Comment 1

[Benjamin Beurdouche [:beurdouche]]

It seems that the MSVS 2022 build works if a recent gyp-next is configured properly
https://github.com/beurdouche/nss/actions/runs/7139099956/workflow