Closed Bug 1810518 Opened 2 years ago Closed 2 years ago

[Experiment] A validation error is displayed in the "Browser Console" when trying to enroll in the "Import experiment: Image (new users)" experiments on Firefox 100 to 103 versions

Categories

(Firefox :: Messaging System, defect, P1)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
Iteration:
111.1 - Jan 16 - Jan 27
Tracking Status
firefox-esr102 --- unaffected
firefox109 --- unaffected
firefox110 --- unaffected
firefox111 --- unaffected
firefox112 --- fixed

People

(Reporter: mcoman, Assigned: emcminn)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Attached image rec of the issue.gif

[Notes]:

  • The following validation error is displayed in the "Browser Console": Error

[Affected versions]:

  • Firefox Release 100.0.2 - Build ID: 20220519220738
  • Firefox Release 101.0.1 - Build ID: 20220608170832
  • Firefox Release 102.0.1 - Build ID: 20220705093820
  • Firefox Release 103.0.2 - Build ID: 20220808125904

[Affected Platforms]:

  • Windows 10 x64
  • macOS 12.6.1
  • Linux Mint 20.2

[Prerequisites]:

[Steps to reproduce]:

  1. Navigate to the profile folder from prerequisites and paste the "user.js" file.
  2. Open the browser using the profile from the prerequisites.
  3. Navigate to the "about:studies" page and observe the listed experiments.

[Expected result]:

  • The "import-bookmarks-image-and-segmentation-en" experiment is displayed.

[Actual result]:

  • The "import-bookmarks-image-and-segmentation-en" experiment is NOT displayed.

[Additional Notes]:

  • This issue is also reproducible with the import experiments for the DE and FR regions.
  • This issue is no longer reproducible on Firefox 104 and above versions.
  • Attached is a screen recording of the issue:

The schema for Firefox Messaging System did not support empty messages in 100-103.

To work around this, we can include a dummy message in the control branch that has targeting: false so that it will never be shown.

We cannot use the schema validation opt-out because that was added in Firefox 107.

Assignee: nobody → emcminn
Iteration: --- → 111.1 - Jan 16 - Jan 27
Priority: -- → P1

This has been fixed by adding the following dummy message to the control branch:

{
  "id": "import-bookmarks-image-and-segmentation-en:control",
  "template": "spotlight",
  "groups": [],
  "content": {
    "template": "multistage",
    "transitions": true,
    "screens": [
      {
        "content": {}
      }
    ]
  },
  "frequency": {
    "lifetime": 1
  },
  "trigger": {
    "id": "defaultBrowserCheck"
  },
  "targeting": "false"
}

targeting: false will ensure the message is not seen and no impression is sent.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED

Could have been fixed by increasing the minimum version of the experiment and keeping the {} message value? If so, should it be updated to simplify for future experiments that clone it?

Flags: needinfo?(emcminn)

Yes I think so - this fix had already been seen by QA so I didn't want to give them another thing. However now it sounds like they'll be running another round of tests anyway, so I can update the fix for simplicity's sake.

Flags: needinfo?(emcminn)
Regressed by: 1752665

Set release status flags based on info from the regressing bug 1752665

This was part of the testing performed on [QA-1733] import-bookmarks-image-and-segmentation request. Considering this I am marking this issue as Verified.

Status: RESOLVED → VERIFIED

Set release status flags based on info from the regressing bug 1752665

marking as fixed even though it was fixed two months ago, to prevent the bot from picking it up again

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: