1810627 - Allow to build without a wasi sysroot

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1810627 - Allow to build without a wasi sysroot.

On e.g. Debian unstable, the wasi SDK is available via packages in a
multiarch fashion, which doesn't require the --sysroot flag being passed
to the compiler.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93b94212020f
Allow to build without a wasi sysroot. r=firefox-build-system-reviewers,ahochheiden

Comment 3

[Norisz Fay [:noriszfay]]

Backed out for causing build bustages

Backout link

Push with failures

Failure log

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b49ff59bb2cd
Allow to build without a wasi sysroot. r=firefox-build-system-reviewers,ahochheiden

Comment 5

[Noemi Erli[:noemi_erli]]

Backed out 3 changesets (Bug 1747145, Bug 1810627) for causing mochitest failures in /test_webassembly_compile.html

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=PY_yiSmZRHWHdwtpz1AReg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Ctsan%2Copt%2Cmochitests%2Ctest-linux1804-64-tsan-qr%2Fopt-mochitest-plain%2C12&revision=b49ff59bb2cd5eabb09913c8f6d685f8382dff48

Log: https://treeherder.mozilla.org/logviewer?job_id=402747935&repo=autoland&lineNumber=2975

Backout: https://hg.mozilla.org/integration/autoland/rev/3057a2275d31d605e8cade763c03d08fca0806e5

Comment 6

[Mike Hommey [:glandium]]

This and bug 1747145 are, in practice, no-ops for CI. That some random stuff happens to have started failing on this landing has be a coincidence, maybe one involving sccache somehow. As a matter of fact, the same test didn't fail on try. I'm relanding and we'll see how it goes.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c789f2627ca
Allow to build without a wasi sysroot. r=firefox-build-system-reviewers,ahochheiden

Comment 8

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #6)

This and bug 1747145 are, in practice, no-ops for CI. That some random stuff happens to have started failing on this landing has be a coincidence, maybe one involving sccache somehow. As a matter of fact, the same test didn't fail on try. I'm relanding and we'll see how it goes.

In fact, it looks like it was still happening after the backout.

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0c789f2627ca

Comment 10

[Mike Hommey [:glandium]]

Comment on attachment 9312535 [details]
Bug 1810627 - Allow to build without a wasi sysroot.

Beta/Release Uplift Approval Request

• User impact if declined: Build-only change that is a no-op in practice for most builds. It allows downstreams like Debian to enable wasm sandboxing with their packaged wasi SDK.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1747145
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): See above
• String changes made/needed: N/A
• Is Android affected?: No

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: See beta request
• User impact if declined:
• Fix Landed on Version: 111
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):

Comment 11

[Pascal Chevrel (relman team) -> :pascalc]

Comment on attachment 9312535 [details]
Bug 1810627 - Allow to build without a wasi sysroot.

Approved for 110 beta 4, thanks.

Comment 12

[Pascal Chevrel (relman team) -> :pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/0eb267712c57

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9312535 [details]
Bug 1810627 - Allow to build without a wasi sysroot.

Approved for 102.8esr.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/30467f249e38