1810653 - Update feature_callout_second_screen_positioned_left_of_element for the new screen it's testing

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Shane Hughes [:aminomancer]]

The test feature_callout_second_screen_positioned_left_of_element was originally written to test arrow_position: "end" but with the Colorways callouts removed, there are no messages with that position. So it's actually testing a screen with arrow_position: "bottom" but it's still comparing the left positions of the callout and parent, and still using the parent selector for the old tour screen 3 (the colorways card, which is now hidden). We should update this and maybe add another test that artificially sets arrow_position: "end" so it can be tested, while such messages are absent from the tree.

Comment 1

[Shane Hughes [:aminomancer]]

Though positioning a callout left of the parent is a bit awkward now, as every card on fx view is vertically oriented. With the removal of the colorways card, there is no right column anymore, just a central column divided into rows. So in test environments (which have very diminutive screen resolutions), there may not be room for a callout between the left edge of the viewport and the left edge of the central column. This may cause our test to require zooming out to make room (like the resize test)

Comment 2

[Shane Hughes [:aminomancer]]

Attachment: Bug 1810653 - Update feature callout position tests. r=jprickett

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1802918

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a57c7222c05
Update feature callout position tests. r=jprickett

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/3a57c7222c05

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:aminomancer, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox110 to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Shane Hughes [:aminomancer]]

Comment on attachment 9312538 [details]
Bug 1810653 - Update feature callout position tests. r=jprickett

Beta/Release Uplift Approval Request

• User impact if declined: None. The uplift is just necessary to relieve permanent test failures on mozilla-beta.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only test files are affected, which have been verified to pass on Nightly and beta simulation
• String changes made/needed:
• Is Android affected?: No

Comment 8

[Pascal Chevrel (relman team) -> :pascalc]

Comment on attachment 9312538 [details]
Bug 1810653 - Update feature callout position tests. r=jprickett

Approved for 110 beta 3, thanks

Comment 9

[Pascal Chevrel (relman team) -> :pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/f8c0a0f47243

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/aff9defd54c9