Closed Bug 1810662 Opened 1 year ago Closed 1 year ago

make "item should have finite clip with respect to aASR" asserts non-fatal

Categories

(Core :: Web Painting, task)

task

Tracking

()

RESOLVED FIXED
111 Branch
Tracking Status
firefox111 --- fixed

People

(Reporter: tnikkel, Assigned: tnikkel)

References

Details

Attachments

(1 file)

We'll try making these non-fatal and see what kind of things happen in the fuzzers.

Assignee: nobody → tnikkel
Status: NEW → ASSIGNED
Pushed by tnikkel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/16b94d4482a2
Make "item should have finite clip with respect to aASR" asserts non-fatal. r=botond

Backed out for causing for causing wpt failures in /html/semantics/interactive-elements/the-dialog-element/fixed-position-child-with-transformed-ancestor.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/35f8b8a01747061995b4cdcc821c09f15936b9ea

Push with failures

Failure log

Flags: needinfo?(tnikkel)

I just checked an earlier green job that runs this test, the test is hitting a fatal assert, but the job somehow manages to stay green! The same test is disabled on linux and windows because it hits the same fatal assert but it actually turns those jobs orange.

So I'll enable this test on all platforms and mark it as expecting asserts (or disable on debug it if that's not possible with this type of test). And I'll file a bug about that failure not turning the job orange.

Looking at this more, the ini has ERROR as an expected outcome, and that seems to be why it's green on macos. For some reason linux and windows can't get away with a fatal assert if the expected outcome is error. So I guess we don't need a bug on that, it's a little weird, but not horrible.

Flags: needinfo?(tnikkel)
Pushed by tnikkel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1147d63e7ca4
Make "item should have finite clip with respect to aASR" asserts non-fatal. r=botond
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: