Computed value of font-feature-settings and font-variation-settings should de-duplicate tags
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox111 | --- | fixed |
People
(Reporter: jfkthame, Assigned: jfkthame)
References
Details
Attachments
(2 files)
The CSS Fonts description of the font-variation-settings
property says:
If the same axis name appears more than once, the value associated with the last appearance supersedes any previous value for that axis. This deduplication is observable by accessing the computed value of this property.
Currently, we don't implement this; we just use the list as specified, with any duplicated axes still present. So that's clearly a bug.
For font-feature-settings
there is similar text, although this currently conflicts with the summary description of the computed value, which simply says "as specified". I filed https://github.com/w3c/csswg-drafts/issues/8296 to get this fixed.
Given that Chris (as CSS Fonts editor) agreed in the issue that the desired behavior is to de-duplicate the computed value (and so the summary is wrong), I propose to go ahead and make the same fix for both properties.
Assignee | ||
Comment 1•1 year ago
|
||
Updated•1 year ago
|
Assignee | ||
Comment 2•1 year ago
|
||
Depends on D167012
Pushed by jkew@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/17729df522e3 De-dup items with the same tag in the computed value of font-feature-settings and font-variation-settings. r=emilio https://hg.mozilla.org/integration/autoland/rev/51d5319d3ce9 Test/metadata updates for corrected font-{feature,variation}-settings computed style and interpolation behaviors. r=emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38063 for changes under testing/web-platform/tests
Comment 5•1 year ago
|
||
Backed out for causing test_transitions_per_property.html failures.
Failure log: https://treeherder.mozilla.org/logviewer?job_id=402896396&repo=autoland
Backout link: https://hg.mozilla.org/integration/autoland/rev/50a7bd104bba42061e944354a63eef0e2b474c58
Assignee | ||
Comment 6•1 year ago
•
|
||
@Cosmin, I believe that failure is from bug 1352757 which landed immediately before this one.
Comment 7•1 year ago
|
||
Yep, you're right. Will reland this and take care of the other. Thanks.
Upstream PR was closed without merging
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7cd1a5a706cf De-dup items with the same tag in the computed value of font-feature-settings and font-variation-settings. r=emilio https://hg.mozilla.org/integration/autoland/rev/6a7b19193977 Test/metadata updates for corrected font-{feature,variation}-settings computed style and interpolation behaviors. r=emilio
Assignee | ||
Updated•1 year ago
|
Comment 10•1 year ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7cd1a5a706cf
https://hg.mozilla.org/mozilla-central/rev/6a7b19193977
Upstream PR merged by moz-wptsync-bot
Description
•