Closed Bug 1810717 Opened 1 year ago Closed 1 year ago

Computed value of font-feature-settings and font-variation-settings should de-duplicate tags

Categories

(Core :: CSS Parsing and Computation, defect)

defect

Tracking

()

RESOLVED FIXED
111 Branch
Tracking Status
firefox111 --- fixed

People

(Reporter: jfkthame, Assigned: jfkthame)

References

Details

Attachments

(2 files)

The CSS Fonts description of the font-variation-settings property says:

If the same axis name appears more than once, the value associated with the last appearance supersedes any previous value for that axis. This deduplication is observable by accessing the computed value of this property.

Currently, we don't implement this; we just use the list as specified, with any duplicated axes still present. So that's clearly a bug.

For font-feature-settings there is similar text, although this currently conflicts with the summary description of the computed value, which simply says "as specified". I filed https://github.com/w3c/csswg-drafts/issues/8296 to get this fixed.

Given that Chris (as CSS Fonts editor) agreed in the issue that the desired behavior is to de-duplicate the computed value (and so the summary is wrong), I propose to go ahead and make the same fix for both properties.

Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/17729df522e3
De-dup items with the same tag in the computed value of font-feature-settings and font-variation-settings. r=emilio
https://hg.mozilla.org/integration/autoland/rev/51d5319d3ce9
Test/metadata updates for corrected font-{feature,variation}-settings computed style and interpolation behaviors. r=emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38063 for changes under testing/web-platform/tests
Flags: needinfo?(jfkthame) → needinfo?(csabou)

Yep, you're right. Will reland this and take care of the other. Thanks.

Flags: needinfo?(csabou)
Upstream PR was closed without merging
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7cd1a5a706cf
De-dup items with the same tag in the computed value of font-feature-settings and font-variation-settings. r=emilio
https://hg.mozilla.org/integration/autoland/rev/6a7b19193977
Test/metadata updates for corrected font-{feature,variation}-settings computed style and interpolation behaviors. r=emilio
Severity: -- → S3
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: