Closed Bug 1810732 Opened 1 year ago Closed 1 year ago

Perma browser/components/extensions/test/browser/browser_ext_incognito_views.js | Error: Error: openPopup requires a user gesture :: Async*testWindow@moz-extension://... when Gecko 111 merges to Beta on 2023-02-13

Categories

(WebExtensions :: Untriaged, defect)

Product:
WebExtensions
Component:
Untriaged
Version:
Firefox 111
Type:
defect

Tracking

(firefox-esr102 unaffected, firefox109 unaffected, firefox110 fixed, firefox111+ verified)

Status:
VERIFIED FIXED
Milestone:
111 Branch
Tracking Flags:
Tracking Status
firefox-esr102 --- unaffected
firefox109 --- unaffected
firefox110 --- fixed
firefox111 + verified

People

(Reporter: mlaza, Assigned: robwu)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1810732 - Set pref to enable openPopup in browser_ext_incognito_views.js
48 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-beta+
Details | Review

Central-as-beta-simulation

How to run these simulations

Failure log

task 2023-01-17T12:02:06.990Z] 12:02:06     INFO - TEST-START | browser/components/extensions/test/browser/browser_ext_incognito_views.js
[task 2023-01-17T12:02:07.106Z] 12:02:07     INFO - TEST-INFO | started process screentopng
[task 2023-01-17T12:02:07.292Z] 12:02:07     INFO - TEST-INFO | screentopng: exit 0
[task 2023-01-17T12:02:07.293Z] 12:02:07     INFO - Buffered messages logged at 12:02:06
[task 2023-01-17T12:02:07.295Z] 12:02:07     INFO - Entering test bound testIncognitoViews
[task 2023-01-17T12:02:07.297Z] 12:02:07     INFO - Extension loaded
[task 2023-01-17T12:02:07.298Z] 12:02:07     INFO - Buffered messages logged at 12:02:07
[task 2023-01-17T12:02:07.298Z] 12:02:07     INFO - Console message: Warning: attempting to write 17051 bytes to preference extensions.webextensions.uuids. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file.
[task 2023-01-17T12:02:07.301Z] 12:02:07     INFO - Console message: Warning: attempting to write 10732 bytes to preference browser.uiCustomization.state. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file.
[task 2023-01-17T12:02:07.301Z] 12:02:07     INFO - Buffered messages finished
[task 2023-01-17T12:02:07.304Z] 12:02:07     INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_incognito_views.js | Error: Error: openPopup requires a user gesture :: Async*testWindow@moz-extension://dccbb9a8-57a9-4585-88de-a80fa7e67c72/%7B084a3d43-d2d1-49fa-9356-21b15bbf8c21%7D.js:19:37
[task 2023-01-17T12:02:07.304Z] 12:02:07     INFO - @moz-extension://dccbb9a8-57a9-4585-88de-a80fa7e67c72/%7B084a3d43-d2d1-49fa-9356-21b15bbf8c21%7D.js:60:17
[task 2023-01-17T12:02:07.304Z] 12:02:07     INFO - async*@moz-extension://dccbb9a8-57a9-4585-88de-a80fa7e67c72/%7B084a3d43-d2d1-49fa-9356-21b15bbf8c21%7D.js:92:7
[task 2023-01-17T12:02:07.304Z] 12:02:07     INFO -  - 
[task 2023-01-17T12:02:07.304Z] 12:02:07     INFO - Stack trace:
[task 2023-01-17T12:02:07.304Z] 12:02:07     INFO - chrome://mochikit/content/browser-test.js:test_ok:1449
[task 2023-01-17T12:02:07.304Z] 12:02:07     INFO - chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:testHandler:87
[task 2023-01-17T12:02:07.304Z] 12:02:07     INFO - chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:testResult:97
[task 2023-01-17T12:02:07.304Z] 12:02:07     INFO - resource://specialpowers/SpecialPowersChild.sys.mjs:listener:1989
[task 2023-01-17T12:02:07.304Z] 12:02:07     INFO - resource://specialpowers/SpecialPowersChild.sys.mjs:loadExtension/<:1919
[task 2023-01-17T12:02:07.304Z] 12:02:07     INFO - resource://specialpowers/SpecialPowersChild.sys.mjs:receiveMessage:222
[task 2023-01-17T12:02:07.304Z] 12:02:07     INFO - JSActor query*resource://specialpowers/SpecialPowersParent.sys.mjs:resultListener:1113
[task 2023-01-17T12:02:07.304Z] 12:02:07     INFO - resource://gre/modules/ExtensionCommon.jsm:emit:323
[task 2023-01-17T12:02:07.304Z] 12:02:07     INFO - resource://gre/modules/Extension.jsm:receiveMessage:2665
[task 2023-01-17T12:02:07.304Z] 12:02:07     INFO - MessageListener.receiveMessage*resource://gre/modules/Extension.jsm:Extension:2469
[task 2023-01-17T12:02:07.304Z] 12:02:07     INFO - resource://testing-common/ExtensionTestCommon.jsm:generate:691
[task 2023-01-17T12:02:07.304Z] 12:02:07     INFO - resource://specialpowers/SpecialPowersParent.sys.mjs:receiveMessage:1110
[task 2023-01-17T12:02:07.304Z] 12:02:07     INFO - JSActor query*resource://specialpowers/SpecialPowersChild.sys.mjs:loadExtension:1981
[task 2023-01-17T12:02:07.305Z] 12:02:07     INFO - chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:ExtensionTestUtils.loadExtension:128
[task 2023-01-17T12:02:07.305Z] 12:02:07     INFO - chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_incognito_views.js:testIncognitoViews:13
[task 2023-01-17T12:02:07.306Z] 12:02:07     INFO - chrome://mochikit/content/browser-test.js:handleTask:1037
[task 2023-01-17T12:02:07.306Z] 12:02:07     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1109
[task 2023-01-17T12:02:07.306Z] 12:02:07     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1244
[task 2023-01-17T12:02:07.306Z] 12:02:07     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1026
[task 2023-01-17T12:02:07.307Z] 12:02:07     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1036
[task 2023-01-17T12:02:07.308Z] 12:02:07     INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-01-17T12:02:07.309Z] 12:02:07     INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_incognito_views.js | incognito-views - 
[task 2023-01-17T12:02:07.310Z] 12:02:07     INFO - Stack trace:
[task 2023-01-17T12:02:07.310Z] 12:02:07     INFO - chrome://mochikit/content/browser-test.js:test_ok:1449
[task 2023-01-17T12:02:07.311Z] 12:02:07     INFO - chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:testResult:94
[task 2023-01-17T12:02:07.311Z] 12:02:07     INFO - resource://specialpowers/SpecialPowersChild.sys.mjs:listener:1989
[task 2023-01-17T12:02:07.312Z] 12:02:07     INFO - resource://specialpowers/SpecialPowersChild.sys.mjs:loadExtension/<:1919
[task 2023-01-17T12:02:07.312Z] 12:02:07     INFO - resource://specialpowers/SpecialPowersChild.sys.mjs:receiveMessage:222
[task 2023-01-17T12:02:07.313Z] 12:02:07     INFO - JSActor query*resource://specialpowers/SpecialPowersParent.sys.mjs:resultListener:1113
[task 2023-01-17T12:02:07.314Z] 12:02:07     INFO - resource://gre/modules/ExtensionCommon.jsm:emit:323
[task 2023-01-17T12:02:07.314Z] 12:02:07     INFO - resource://gre/modules/Extension.jsm:receiveMessage:2665
[task 2023-01-17T12:02:07.314Z] 12:02:07     INFO - MessageListener.receiveMessage*resource://gre/modules/Extension.jsm:Extension:2469
[task 2023-01-17T12:02:07.314Z] 12:02:07     INFO - resource://testing-common/ExtensionTestCommon.jsm:generate:691
[task 2023-01-17T12:02:07.315Z] 12:02:07     INFO - resource://specialpowers/SpecialPowersParent.sys.mjs:receiveMessage:1110
[task 2023-01-17T12:02:07.315Z] 12:02:07     INFO - JSActor query*resource://specialpowers/SpecialPowersChild.sys.mjs:loadExtension:1981
[task 2023-01-17T12:02:07.315Z] 12:02:07     INFO - chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:ExtensionTestUtils.loadExtension:128
[task 2023-01-17T12:02:07.315Z] 12:02:07     INFO - chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_incognito_views.js:testIncognitoViews:13
[task 2023-01-17T12:02:07.316Z] 12:02:07     INFO - chrome://mochikit/content/browser-test.js:handleTask:1037
[task 2023-01-17T12:02:07.316Z] 12:02:07     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1109
[task 2023-01-17T12:02:07.316Z] 12:02:07     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1244
[task 2023-01-17T12:02:07.316Z] 12:02:07     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1026
[task 2023-01-17T12:02:07.316Z] 12:02:07     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1036
[task 2023-01-17T12:02:07.317Z] 12:02:07     INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_incognito_views.js | test result correct -

Check comments on Bug 1775559.

Regressed by: 1808921

:Mariam-Vasile Laze, the regressor landed in 110 - I guess it would have impacted there too, though 110 now already in beta

tracking-firefox111: ? → +
Flags: needinfo?(mlaza)

(In reply to Donal Meehan [:dmeehan] from comment #1)

:Mariam-Vasile Laze, the regressor landed in 110 - I guess it would have impacted there too, though 110 now already in beta

It did, actually on yesterday's betasim it was also perma (we checked today with some retriggs) but was not discovered as a perma... it was still 110 and included the regressor.

It started to perma fail after fix for Bug 1808921 was landed.

Flags: needinfo?(mlaza) → needinfo?(dmeehan)
Keywords: regression
Keywords: regression

Setting 110 to affected per comment 2

status-firefox110: unaffected → affected
Flags: needinfo?(dmeehan)

:robwu, since you are the author of the regressor, bug 1808921, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Flags: needinfo?(rob)
Assignee: nobody → rob
Status: NEW → ASSIGNED
Flags: needinfo?(rob)
Blocks: 1775559
Pushed by rob@robwu.nl:
https://hg.mozilla.org/integration/autoland/rev/ff3f0f55882f
Set pref to enable openPopup in browser_ext_incognito_views.js r=rpl

https://hg.mozilla.org/mozilla-central/rev/ff3f0f55882f

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox111: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch

The patch landed in nightly and beta is affected.
:robwu, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox110 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(rob)

Fix verified in today's beta-sim.

Status: RESOLVED → VERIFIED
status-firefox111: fixed → verified

Comment on attachment 9312868 [details]
Bug 1810732 - Set pref to enable openPopup in browser_ext_incognito_views.js

Beta/Release Uplift Approval Request

  • User impact if declined: None. This is test-only. On beta/release, the test introduced in bug 1808921 will permafail.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Test-only change to set a pref to true in a test. The pref defaults to true on Nightly, but is false on non-Nightly.
  • String changes made/needed:
  • Is Android affected?: No
Flags: needinfo?(rob)
Attachment #9312868 - Flags: approval-mozilla-beta?

Comment on attachment 9312868 [details]
Bug 1810732 - Set pref to enable openPopup in browser_ext_incognito_views.js

Approved for 110 beta 3, thanks

Attachment #9312868 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: