1810800 - A pdf can be too much zoomed with the wheel when ctrl is pressed outside of the viewer

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Calixte Denizet (:calixte)]

STR:

• open a pdf
• click outside Firefox to remove any focus
• press ctrl
• move the mouse on the viewer and play with the wheel.

The document is a way too much zoomed/unzoomed.

Comment 1

[Jonas Jenwald [:Snuffleupagus]]

It seems to me that this might be quite easy to work-around, by simply using a "mouseleave" eventListener that forcibly sets PDFViewerApplication._isCtrlKeyDown = true.

Comment 2

[Pascal Chevrel (relman team) -> :pascalc]

Calixte, are you working on this regression for our releases in flight? Should we wontfix for 110? Thanks

Comment 3

[Jonas Jenwald [:Snuffleupagus]]

I've got a WIP patch locally, along the lines in https://bugzilla.mozilla.org/show_bug.cgi?id=1810800#c1 since that seemed to work, so I could "steal" this bug and submit a patch :-)

Comment 4

[Calixte Denizet (:calixte)]

Attachment: pr 15957: Try to avoid to interpret wheel events as pinch-to-zoom ones (bug 1810800)

Comment 5

[Pascal Chevrel (relman team) -> :pascalc]

Calixte, are you planning an uplift for beta or should your fix ride the 111 train? Thanks.

Comment 6

[Calixte Denizet (:calixte)]

Attachment: Bug 1810800 - Fix zooming with the mouse wheel in PDF.js r=#pdfjs-reviewers

Comment 7

[Calixte Denizet (:calixte)]

Comment on attachment 9314875 [details]
Bug 1810800 - Fix zooming with the mouse wheel in PDF.js r=#pdfjs-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: The users could be annoyed when they want to zoom a pdf in using ctrl+mouse wheel.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See https://bugzilla.mozilla.org/show_bug.cgi?id=1810800#c0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a small change and it can be easily verified by QE.
• String changes made/needed:
• Is Android affected?: No

Comment 8

[Pascal Chevrel (relman team) -> :pascalc]

Comment on attachment 9314875 [details]
Bug 1810800 - Fix zooming with the mouse wheel in PDF.js r=#pdfjs-reviewers

Approved for 110 beta 8, thanks.

Comment 9

[Pascal Chevrel (relman team) -> :pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/e1b0d6b0694a

Comment 10

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Reproduced the issue on Firefox 110.0b7 under Windows 11 by following the STR from Comment 0.

The issue is no longer reproducible on Firefox 111.0a1 (2023-01-30) and Firefox 110.0b8 (treeherder build) on the same system. Seems that Ubuntu and macOS only scrolls the PDF when holding ctrl with focus outside Firefox.