Move _extensionID and _locale out of SearchEngine and into AddonSearchEngine
Categories
(Firefox :: Search, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox114 | --- | fixed |
People
(Reporter: standard8, Assigned: victoria.o.ajala, Mentored)
Details
(Whiteboard: [lang=js])
Attachments
(1 file)
We still have _extensionID references in SearchEngine, we should investigate moving them out to AddonSearchEngine, since they are only really relevant there.
|
Reporter | |
Comment 1•1 year ago
|
||
There's also _locale that we should move as well.
|
|
Reporter | |
Comment 2•1 year ago
|
||
I believe the work here is possible, bug 1819102 is something similar that was done for a few OpenSearchEngine fields. Use searchfox to find the class definitions/look at the source.
|
Assignee | |
Comment 3•1 year ago
|
||
Hi @Mark Banner, I would like to work on this bug, I'm currently going through the comments and the similar bug you included in [comment 3] to understand how to go about it. I've used searchfox to find the specific files that need fixing. I assume the fix should be moving _extensionID references in toolkit/components/search/SearchEngine.sys.mjs to toolkit/components/search/AddonSearchEngine.sys.mjs as well as _locale.
|
|
Reporter | |
Comment 4•1 year ago
|
||
(In reply to Victoria Ajala from comment #3)
Hi @Mark Banner, I would like to work on this bug, I'm currently going through the comments and the similar bug you included in
[comment 3]to understand how to go about it. I've used searchfox to find the specific files that need fixing. I assume the fix should be moving_extensionIDreferences intoolkit/components/search/SearchEngine.sys.mjstotoolkit/components/search/AddonSearchEngine.sys.mjsas well as_locale.
Generally yes, but where's there are functions (e.g. this one) in SearchEngine that use _extensionID, we'll need to keep those returning an appropriate value, and override the function in AddonSearchEngine.
|
|
Assignee | |
Comment 5•1 year ago
|
||
|
|
Assignee | |
Comment 6•1 year ago
|
||
(In reply to Mark Banner (:standard8) from comment #4)
Generally yes, but where's there are functions (e.g. this one) in
SearchEnginethat use_extensionID, we'll need to keep those returning an appropriate value, and override the function inAddonSearchEngine.
I've created a patch for this but I've only removed the _extensionID function in the SearchEngine. I'm unsure where and how to override the function in AddonSearchEngine.
|
||
Updated•1 year ago
|
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c8fc4588a1c6 Moved _extensionID and _locale functions out of SearchEngine and into AddonSearchEngine. r=Standard8
|
||
Comment 8•1 year ago
|
||
| bugherder | ||
Description
•