1810860 - Intermittent TV /tests/toolkit/components/alerts/test/test_principal.html logged result after SimpleTest.finish(): Alerts should not be present at the start of the test.

Status: RESOLVED INCOMPLETE

(Toolkit Graveyard :: Notifications and Alerts, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: abutkovits [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=402685764&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/AhObZsCkR4iUsvfulh7Zng/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/AhObZsCkR4iUsvfulh7Zng/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---

[task 2023-01-17T19:31:33.356Z] 19:31:33     INFO - TEST-START | toolkit/components/alerts/test/test_principal.html
[task 2023-01-17T19:31:33.414Z] 19:31:33     INFO - GECKO(1609) | MEMORY STAT | vsize 2490MB | residentFast 108MB | heapAllocated 7MB
[task 2023-01-17T19:31:33.472Z] 19:31:33     INFO - TEST-OK | toolkit/components/alerts/test/test_principal.html | took 115ms
[task 2023-01-17T19:31:33.539Z] 19:31:33    ERROR - TEST-UNEXPECTED-FAIL | /tests/toolkit/components/alerts/test/test_principal.html logged result after SimpleTest.finish(): Alerts should not be present at the start of the test.
[task 2023-01-17T19:31:33.587Z] 19:31:33     INFO - TEST-START | Shutdown

Comment 1

[Nick Alexander :nalexander [he/him]]

nrishel: huh, a Linux failure. Dig in?

Comment 2

[Nick Rishel [:nrishel]]

Attachment: Bug 1810860 - Fix `test_principal` fail on test verification runs by confirming XUL alert windows are closed before concluding the test. r=nalexander

Comment 3

[Nick Rishel [:nrishel]]

Attachment: Bug 1810860 - Post: Reuse logic from `test_principal` to wait for `alert:alert` window closure without timeouts. r=nalexander

Comment 4

[Nick Rishel [:nrishel]]

Attachment: Bug 1810860 - Pre 1: Generalize test verifying no prior XUL alerts to all `toolkit/components/alerts/test` mochitests. r=nalexander

Comment 5

[Nick Rishel [:nrishel]]

Attachment: Bug 1810860 - Post 1: Add no XUL alert window pre-test and cleanup for all `toolkit/components/alerts/test` tests. r=nalexander

Comment 6

[Intermittent Failures Robot]

9 failures in 3717 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 9

Platform and build breakdown:

• linux1804-64-qr: 2
  • debug: 1
  • opt: 1
• windows10-64-2004-qr: 2
  • debug: 1
  • opt: 1
• macosx1015-64-qr: 2
  • debug: 1
  • opt: 1
• linux1804-64-tsan-qr: 1
  • opt: 1
• windows10-32-2004-qr: 2
  • debug: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1810860&startday=2023-01-16&endday=2023-01-22&tree=all

Comment 7

[Nick Rishel [:nrishel]]

Attachment: Bug 1810860 - Pre 2: Modify `toolkit/components/alerts/test` tests to handle async tests with `async_task` and Promises. r=nalexander

Replaces async via callbacks and SimpleTest.waitForExplicitFinish()/SimpleTest.finish() pairs.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30c8a14356de
Pre 1: Generalize test verifying no prior XUL alerts to all `toolkit/components/alerts/test` mochitests. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/1c54878a5727
Pre 2: Modify `toolkit/components/alerts/test` tests to handle async tests with `async_task` and Promises. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/72d1653cafc0
Fix `test_principal` fail on test verification runs by confirming XUL alert windows are closed before concluding the test. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/87cdb2169287
Post: Add no XUL alert window pre-test and cleanup for all `toolkit/components/alerts/test` tests. r=nalexander

Comment 9

[Marian-Vasile Laza]

Backed out 5 changesets (Bug 1809464, Bug 1810860) for causing multiple mochitest exeption failures.
Backout link
Push with failures <--> 7
Failure Log
Also Failure Log
Also Failure Log
Also Failure Log

Comment 10

[Intermittent Failures Robot]

4 failures in 3914 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 4

Platform and build breakdown:

• windows10-64-2004-qr: 2
  • debug: 1
  • opt: 1
• windows10-32-2004-qr: 2
  • debug: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1810860&startday=2023-01-23&endday=2023-01-29&tree=all

Comment 11

[Nick Rishel [:nrishel]]

Attachment: Bug 1810860 - Post 2: `skip-if` was accidentally removed in revision 5cff19bd3c53. As no intermittent test failures have re-emerged for two years we can assume Bug 1407296 has since been resolved. r=nalexander

Comment 12

[Nick Rishel [:nrishel]]

Attachment: Bug 1810860 - Post 2: `skip-if` was accidentally removed in revision 5cff19bd3c53. As no intermittent test failures have re-emerged for two years we can assume Bug 1407296 has since been resolved. r=nalexander

Comment 13

[Phabricator Automation]

Comment on attachment 9315294 [details]
Bug 1810860 - Post 2: skip-if was accidentally removed in revision 5cff19bd3c53. As no intermittent test failures have re-emerged for two years we can assume Bug 1407296 has since been resolved. r=nalexander

Revision D168503 was moved to bug 1809464. Setting attachment 9315294 [details] to obsolete.

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1809464

Comment 15

[Nick Rishel [:nrishel]]

Bug was "fixed" as part of changes from Bug 1809464. Leaving bug open as a tracking issue for the more general problem of not being able to run test-verify for test_principal.

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:nrishel, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 17

[BugBot [:suhaib / :marco/ :calixte]]

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit auto_nag documentation.