1810906 - [wmfme] Implement basic classes for media engine CDM support

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P1)

Description

[Alastor Wu [:alwu]]

https://learn.microsoft.com/en-us/windows/win32/api/mfidl/nn-mfidl-imfcontentprotectionmanager

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1810906 - part1 : implement the content protection manager.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1810906 - part2 : adding includes and missing namespace to fix build errors.

Depends on D167206

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1810906 - part3 : move WMFMediaDataEncoder implementation to its header to fix link errors.

After adding more files, WMFEncoderModule.cpp is no longer in the same
unify build unit with the WMFMediaDataEncoder.cpp. Therefore, we need
to make the implementation of template class WMFMediaDataEncoder
visible in the header file, otherwise the compiler would report link
error of undefined WMFMediaDataEncoder symbol.

Depends on D167303

Comment 4

[Alastor Wu [:alwu]]

Attachment: Bug 1810906 - part4 : implement a proxy to wrap IMFContentDecryptionModule.

Depends on D167304

Comment 5

[Alastor Wu [:alwu]]

Attachment: Bug 1810906 - part5 : implement IMFTrustedInput on MFMediaSource.

Depends on D167305

Comment 6

[Alastor Wu [:alwu]]

Attachment: Bug 1810906 - part6 : expose a method to know if a stream is encrypted.

Depends on D167328

Comment 7

[Alastor Wu [:alwu]]

Attachment: Bug 1810906 - part7 : set CDM proxy to the content protection manager and the media source.

We haven't decided where the CDM proxy is going to be created and
passed, for now let's assume the media engine parent is the entry point
to set the CDM proxy to the content protection manager and the media
source.

Depends on D167329

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2aa16e0149d2
part1 : implement the content protection manager. r=jolin
https://hg.mozilla.org/integration/autoland/rev/89e7ad08b2a2
part2 : adding includes and missing namespace to fix build errors. r=jolin
https://hg.mozilla.org/integration/autoland/rev/f8c3e3b17536
part3 : move WMFMediaDataEncoder implementation to its header to fix link errors. r=jolin
https://hg.mozilla.org/integration/autoland/rev/1eae73e0ba44
part4 : implement a proxy to wrap IMFContentDecryptionModule. r=jolin
https://hg.mozilla.org/integration/autoland/rev/4f3d40be7421
part5 : implement IMFTrustedInput on MFMediaSource. r=jolin
https://hg.mozilla.org/integration/autoland/rev/d274f0432208
part6 : expose a method to know if a stream is encrypted. r=jolin
https://hg.mozilla.org/integration/autoland/rev/587a70264fdd
part7 : set CDM proxy to the content protection manager and the media source. r=jolin

Comment 9

[Natalia Csoregi [:nataliaCs]]

Backed out for MediaDataEncoderTest failures.

• backout: https://hg.mozilla.org/integration/autoland/rev/13590518b03b0ed73bb85717bae7b1b0b0f31dea
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=587a70264fddf290bfb9f3b694660d2bdc335263&selectedTaskRun=fi0SUL5rRn2Urhtxa6rrDw.0
• failure log: https://treeherder.mozilla.org/logviewer?job_id=403277323&repo=autoland&lineNumber=33979

[task 2023-01-23T20:28:52.176Z] 20:28:52     INFO -  TEST-START | MediaDataEncoderTest.H264Encodes
[task 2023-01-23T20:28:52.484Z] 20:28:52  WARNING -  TEST-UNEXPECTED-FAIL | MediaDataEncoderTest.H264Encodes | Value of: AnnexB::IsAnnexB(frame)
[task 2023-01-23T20:28:52.498Z] 20:28:52     INFO -    Actual: true
[task 2023-01-23T20:28:52.498Z] 20:28:52     INFO -  Expected: false @ /builds/worker/checkouts/gecko/dom/media/gtest/TestMediaDataEncoder.cpp:310
[task 2023-01-23T20:28:52.499Z] 20:28:52  WARNING -  TEST-UNEXPECTED-FAIL | MediaDataEncoderTest.H264Encodes | Value of: AnnexB::IsAnnexB(frame)
[task 2023-01-23T20:28:52.499Z] 20:28:52     INFO -    Actual: true
[task 2023-01-23T20:28:52.499Z] 20:28:52     INFO -  Expected: false @ /builds/worker/checkouts/gecko/dom/media/gtest/TestMediaDataEncoder.cpp:310
[task 2023-01-23T20:28:52.499Z] 20:28:52  WARNING -  TEST-UNEXPECTED-FAIL | MediaDataEncoderTest.H264Encodes | Value of: AnnexB::IsAnnexB(frame)
[task 2023-01-23T20:28:52.500Z] 20:28:52     INFO -    Actual: true
[task 2023-01-23T20:28:52.500Z] 20:28:52     INFO -  Expected: false @ /builds/worker/checkouts/gecko/dom/media/gtest/TestMediaDataEncoder.cpp:310

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69cc67e98f6d
part1 : implement the content protection manager. r=jolin
https://hg.mozilla.org/integration/autoland/rev/a1af87093879
part2 : adding includes and missing namespace to fix build errors. r=jolin
https://hg.mozilla.org/integration/autoland/rev/dff599e1e2f9
part3 : move WMFMediaDataEncoder implementation to its header to fix link errors. r=jolin
https://hg.mozilla.org/integration/autoland/rev/0eb21f843fa5
part4 : implement a proxy to wrap IMFContentDecryptionModule. r=jolin
https://hg.mozilla.org/integration/autoland/rev/3b8db5361091
part5 : implement IMFTrustedInput on MFMediaSource. r=jolin
https://hg.mozilla.org/integration/autoland/rev/7e01eac67c8c
part6 : expose a method to know if a stream is encrypted. r=jolin
https://hg.mozilla.org/integration/autoland/rev/646826f7ef25
part7 : set CDM proxy to the content protection manager and the media source. r=jolin

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/69cc67e98f6d
https://hg.mozilla.org/mozilla-central/rev/a1af87093879
https://hg.mozilla.org/mozilla-central/rev/dff599e1e2f9
https://hg.mozilla.org/mozilla-central/rev/0eb21f843fa5
https://hg.mozilla.org/mozilla-central/rev/3b8db5361091
https://hg.mozilla.org/mozilla-central/rev/7e01eac67c8c
https://hg.mozilla.org/mozilla-central/rev/646826f7ef25