1810931 - Update opus to new version 8cf872a186b96085b1bb3a547afd598354ebeb87 from 2023-01-17 20:10:28

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Update Bot]

This update covers 1 commits:

---

8cf872a186b96085b1bb3a547afd598354ebeb87 by Zheng Lv

https://gitlab.xiph.org/xiph/opus/commit/8cf872a186b96085b1bb3a547afd598354ebeb87
Authored: 2022-09-13 14:40:52 +0800
Committed: 2023-01-17 20:10:28 -0800

Make CELT FFT twiddle complex type aligned

This makes kiss_twiddle_cpx 4-byte aligned (instead of 2-byte) for
fixed-point builds. Tested with an armv6j+nofp development board, CELT
encoding becomes 1.4x as fast, and decoding over 2x.

Performance gain is mostly attributed to the proper alignment of the
static const array mdct_twiddles960.

Co-authored-by: David Gao <[e-mail]>
Signed-off-by: Felicia Lim <[e-mail]>

Files Modified:

• celt/kiss_fft.h

---

Comment 1

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=ac586845ac68414f6a03fe28a2434cbeae7e0b20

Comment 2

[Update Bot]

Attachment: Bug 1810931 - Update opus to 8cf872a186b96085b1bb3a547afd598354ebeb87

Comment 3

[Update Bot]

All jobs completed, we found the following issues.

Known Issues (From Push Health):

 browser/components/shell/test/browser_633221.js | application terminated with exit code -11
	- 1 of 4 failed on the same (retriggered) task
	- test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-a11y-checks-6 (NRWcNEi3TGynBtcGxphVlA)

dom/serviceworkers/test/test_sandbox_intercept.html
	- 1 of 4 failed on the same (retriggered) task
	- test-linux1804-64-qr/opt-mochitest-plain-spi-nw-5 (amJLZiEbSpSq4eo8qdM41Q)

gfx/layers/apz/test/mochitest/test_group_scroll_linked_effect.html
	- 1 of 4 failed on the same (retriggered) task
	- test-linux1804-64-qr/opt-mochitest-plain-swr-nofis-3 (AaWRVNH0RpCkSHZkMJq6Eg)

These failures may mean that the library update succeeded; you'll need to review
them yourself and decide. If there are lint failures, you will need to fix them in
a follow-up patch. (Or ignore the patch I made, and recreate it yourself with
./mach vendor media/libopus/moz.yaml.)

In either event, I have done all I can, so you will need to take it from here.
When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b2d14e0bff6
Update opus to 8cf872a186b96085b1bb3a547afd598354ebeb87 r=kinetik

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/5b2d14e0bff6