1811012 - Eliminate nsAppStartupNotifier and special "service," prefix on components

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, task)

Description

[Chris Martin [:cmartin] - OOO until Nov 9]

On mozilla-central, we are about to land D165414, which will eliminate nsAppStartupNotifier and the special service, prefix on categories that it enabled.

In practice, every category started up by nsAppStartupNotifier is a singleton anyway, at which point the entire thing just becomes an overly complex way (2 headers + 1 source file) of calling NS_CreateServicesFromCategory.

Porting this shouldn't be too bad:

1. Replace any #include "nsAppStartupNotifier.h" with #include "nsCategoryManagerUtils.h"
2. Replace any call to nsAppStartupNotifier::NotifyObservers(APPSTARTUP_CATEGORY, subject) with NS_CreateServicesFromCategory("app-startup", subject, "app-startup", nullptr)
3. Find any app-startup components in your XPCOM manifests and remove the service, prefix from them
4. If any of them don't have theservice, prefix, ensure that they are actually singletons (chances are they already are, and probably should've had the prefix all along)
5. Eliminate nsIAppStartupNotifier.h, nsAppStartupNotifier.h, and nsAppStartupNotifier.cpp
6. In our case, we had to update some relevant documentation

Comment 1

[Geoff Lankow (:darktrojan)]

Today is really unfortunate timing but you weren't to know that. Thanks for the heads-up and instructions.

Comment 2

[Chris Martin [:cmartin] - OOO until Nov 9]

(Comment removed - Just ended up talking to Geoff on Matrix)

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1811012 - Eliminate nsAppStartupNotifier and special "service," prefix on components. r=#thunderbird-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/45322ce67587
Eliminate nsAppStartupNotifier and special "service," prefix on components. r=john.bieling