1811097 - [wpt-sync] Sync PR 38045 - VT: Rename domUpdated to updateCallbackDone

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 38045 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38045
Details from upstream follow.

Vladimir Levin <[e-mail]> wrote:

VT: Rename domUpdated to updateCallbackDone

This patch renames the promise as a result of the following resolution:
https://github.com/w3c/csswg-drafts/issues/8144

R=[e-mail], [e-mail]

Change-Id: Ic0d4f3af2569462ccbf7e30fe258f0e52b21286e
Reviewed-on: https://chromium-review.googlesource.com/4178008
WPT-Export-Revision: febf4461f310ba4b0eed69f51582d3e8117e93cd

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ec7ae1ca20a11008853066606f7d2eff2a6a09e

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 10 tests and 1 subtests

Status Summary

Firefox

OK : 10
FAIL: 10

Chrome

OK : 10
FAIL: 10

Safari

OK : 10
FAIL: 10

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-view-transitions/duplicate-tag-rejects-capture.html [wpt.fyi]
  • Two different elements with the same name in the old DOM should skip the transition: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-view-transitions/duplicate-tag-rejects-start.html [wpt.fyi]
  • Two different elements with the same name in the new DOM should skip the transition: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-view-transitions/no-containment-on-new-element-mid-transition.html [wpt.fyi]
  • new element becoming uncontained should skip the transition: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-view-transitions/no-containment-on-new-element.html [wpt.fyi]
  • uncontained new element should skip the transition: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-view-transitions/no-containment-on-old-element.html [wpt.fyi]
  • uncontained old element should skip the transition: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-view-transitions/pseudo-computed-style-stays-in-sync-with-new-element.html [wpt.fyi]
  • computed style on pseudo-element stays in sync with the DOM element: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-view-transitions/ready_resolves_after_dom_before_raf.html [wpt.fyi]
  • updateCallbackDone resolves, then ready resolves with no rAF in between: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-view-transitions/synchronous-callback-skipped-before-run.html [wpt.fyi]
  • finished promise should be resolved if skipTransition() is invoked before a synchronous updateCallbackDone callback is dispatched: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-view-transitions/transition-skipped-from-invalid-callback.html [wpt.fyi]
  • transition skipped because callback has invalid syntax: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-view-transitions/unset-and-initial-view-transition-name.html [wpt.fyi]
  • validates that view-transition-name: unset or initial are ignored: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2b13963d364
[wpt PR 38045] - VT: Rename domUpdated to updateCallbackDone, a=testonly
https://hg.mozilla.org/integration/autoland/rev/e3ca632c80b5
[wpt PR 38045] - Update wpt metadata, a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c2b13963d364
https://hg.mozilla.org/mozilla-central/rev/e3ca632c80b5