Closed Bug 1811143 Opened 1 year ago Closed 1 year ago

Update calendar list header in calendar side panel area

Categories

(Calendar :: Calendar Frontend, task)

Tracking

(Not tracked)

RESOLVED FIXED
111 Branch

People

(Reporter: solange, Assigned: solange)

References

(Blocks 2 open bugs)

Details

Attachments

(3 files)

  • Update the header to say "Calendars"
  • Remove the "add calendar" button from calendar list header
  • The navigation chevron should be where the "add calendar" button was
  • Hover should affect the whole header (full with of the sidebar) and have the bg color as gray 20
  • Animation of opening and closing (use reduced motion:no-preferences)
  • Have a spacer so that the bottom buttons dont come all the way up when calendar is collapsed
Summary: Remove calendar list header in calendar side panel area → Update calendar list header in calendar side panel area
Attachment #9314120 - Attachment description: WIP: Bug 1811143 Update calendar list header in calendar side panel area. → Bug 1811143 Update calendar list header in calendar side panel area. r=aleca,micahilbery
Status: NEW → ASSIGNED
Target Milestone: --- → 111 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/51db5bd34c2a
Update calendar list header in calendar side panel area. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED

This broke browser_interactionTelemetry.js and browser_calDAV_discovery.js. They both want to click on the old .calendar-list-create button. We should update those tests to use the new button. There might also be other tests that try to create calendars with that button (that aren't currently failing due to the existing failures).

Example failures:
https://treeherder.mozilla.org/logviewer?job_id=404046301&repo=comm-central&lineNumber=3178
https://treeherder.mozilla.org/logviewer?job_id=404046319&repo=comm-central&lineNumber=2064

Edit:
also browser_calendarList.js

Let's backout this and fix the tests.
Thanks for spotting the issues.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #9314120 - Attachment description: Bug 1811143 Update calendar list header in calendar side panel area. r=aleca,micahilbery → WIP: Bug 1811143 Update calendar list header in calendar side panel area.
Attachment #9314120 - Attachment description: WIP: Bug 1811143 Update calendar list header in calendar side panel area. → Bug 1811143 Update calendar list header in calendar side panel area. r=aleca

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/5e85bd095d32
Update calendar list header in calendar side panel area. r=aleca

Status: REOPENED → RESOLVED
Closed: 1 year ago1 year ago
Resolution: --- → FIXED
No longer blocks: sn-fp-options
Blocks: 1817039
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: