1811246 - ESLint - enigmailMessengerOverlay.js:2987:13 | 'viewEncryptedPart' is not defined. (no-undef)

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: thunderbird [at] calypsoblue.org
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=402873860&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/TMZ45JugSkO-ut1WicdmIw/runs/0/artifacts/public/logs/live_backing.log

---

mail/base/content/mailCommands.js needs to be added to the `import-globals-from` headers (??)

Comment 2

[Rob Lemley [:rjl]]

TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mail/extensions/openpgp/content/ui/enigmailMessengerOverlay.js:2987:13 | 'viewEncryptedPart' is not defined. (no-undef)

Comment 3

[Geoff Lankow (:darktrojan)]

I haven't yet looked at this because I think viewEncryptedPart itself is broken, so fixing a call to it for linting purposes just hides a problem.

Comment 4

[Kai Engert (:KaiE:)]

A global was defined in the original patch:
https://hg.mozilla.org/comm-central/rev/8bcd8ddcd1ef#l6.13

Now, the global is missing:
https://searchfox.org/comm-central/rev/d07c2e103641f956475b6483efeca41615a317a0/mail/extensions/openpgp/content/ui/enigmailMessengerOverlay.js

This isn't an intermittent, I see it in every cycle.

I don't know why you think this function is broken, I think that's independent of this lint issue.

I will make a TODO for myself to test that function, and if necessary file a regression bug.

Comment 5

[Kai Engert (:KaiE:)]

Ok, it's broken.

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1811246 - Fix linting problem in enigmailMessengerOverlay.js. r=#thunderbird-reviewers

This file lives in a different scope now, so the function call needs to reference the original scope.

Comment 7

[Geoff Lankow (:darktrojan)]

I expected MsgOpenMessageFromString to be broken from all the UI changes, but it isn't. In hindsight that makes sense.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3b7fc186a96b
Fix linting problem in enigmailMessengerOverlay.js. r=aleca

Comment 9

[Intermittent Failures Robot]

5 failures in 3717 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 5

Platform and build breakdown:

• lint: 3
  • opt: 3
• windows10-64-2004-qr: 1
  • debug: 1
• windows10-64-2004-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1811246&startday=2023-01-16&endday=2023-01-22&tree=all