181127 - Forward as Attachment broken

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect)

Description

[Jon Granrose]

On XP in 2002112004, when I try to forward a message as an attachment it fails
with "Sending of message failed.  Please verify that your Mail and Newsgroup
account settings are correct and try again."

This is a major hassle since you can't forward multiple email messages in the
same email unless you use forward as attachment.

Comment 1

[esther]

This was not broken on the 11-19 trunk build.  Yes this is bad. 

Comment 2

[Jean-Francois Ducarroz]

I am looking at it...

Comment 3

[Jean-Francois Ducarroz]

For some reason, NewChannelFromUR failed for the sheme imap-message!

Comment 4

[Jean-Francois Ducarroz]

David Bienvenu found what cause the regression. The recent change in
nsExternalProtocolHandler.cpp for bug 176904 change the way URIs for unkown
protocol are created which cause the logic in nsMsgAttachmentHandler to failed.

Working on a fix...

Comment 5

[Boris Zbarsky [:bzbarsky]]

Jean-Francois, which part of the logic fails exactly?  I can't find any
NS_NewURI or equivalent callers in that file.  :(

Comment 6

[Jean-Francois Ducarroz]

from nsMsgComposeAndSend::AddCompFieldRemoteAttachments, we call nsMsgNewURL
which call NewURI. The internal logic of the attachment handler was conting on
the fact NewURI will return a null uri when procesing a custom mailnews uri.
This is not true anymore, NewURI always return a valid uri now. Patch coming...

Comment 7

[Jean-Francois Ducarroz]

Attachment: Proposed fix, v1

Before calling nsMsgNewURL, detect ourself if we are processing a mailnews url.

Comment 8

[Jean-Francois Ducarroz]

I have tested this patch with those kind of attachment:
local mailbox message
imap message
news message
secure news message
local file attachment
remote attachment (http://)

work great in each cases.

Comment 9

[Cavin Song]

Comment on attachment 106964 [details] [diff] [review]
Proposed fix, v1

r=cavin.

Comment 10

[Boris Zbarsky [:bzbarsky]]

sr=bzbarsky (not sure whether you still want bienvenu to look at the patch, so
leaving flag as-is for now).

Comment 11

[David :Bienvenu]

Comment on attachment 106964 [details] [diff] [review]
Proposed fix, v1

sr=bienvenu

Comment 12

[Jean-Francois Ducarroz]

Fix checked in. Thanks David for your help

Comment 13

[R.K.Aa.]

*** Bug 181321 has been marked as a duplicate of this bug. ***

Comment 14

[Matthias Versen [:Matti]]

*** Bug 181308 has been marked as a duplicate of this bug. ***

Comment 15

[Jean-Francois Ducarroz]

*** Bug 181335 has been marked as a duplicate of this bug. ***

Comment 16

[esther]

using trunk build 20021121 on winxp, macosx and linux this is fixed. Verified

Comment 17

[R.K.Aa.]

*** Bug 181348 has been marked as a duplicate of this bug. ***

Comment 18

[Matthias Versen [:Matti]]

*** Bug 181348 has been marked as a duplicate of this bug. ***

Comment 19

[Aleksey Nogin]

The annoying thing about this bug was that the error message was completely
useless (did not mention "attachment", did not mention what failed). I've filed
an RFE for better error messages - bug 181593. In short, I believe, send error
messages should at least tell which "stage" of the process failed (collecting
attachments, connecting to the SMTP server, SMTP itself).