1811403 - Respect "apz.disable_for_scroll_linked_effects" pref whether to set HasScrollLinkedEffect::Yes

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect, P3)

Description

[Hiroyuki Ikezoe (:hiro)]

here in ClipManager::DefineScrollLayers we just use the return value of Document::HasScrollLinkedEffect, but the function doesn't check the pref value at all.

I am guessing this is one of the reasons of bug 1810874 even if the pref value is true.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1811403 - Respect "apz.disable_for_scroll_linked_effects" pref whether to set HasScrollLinkedEffect flag. r?botond

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1af6fa02884e
Respect "apz.disable_for_scroll_linked_effects" pref whether to set HasScrollLinkedEffect flag. r=botond

Comment 3

[maciek4231]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #0)

here in ClipManager::DefineScrollLayers we just use the return value of Document::HasScrollLinkedEffect, but the function doesn't check the pref value at all.

I am guessing this is one of the reasons of bug 1810874 even if the pref value is true.

I'm not entirely sure I built Firefox with those changes applied correctly (replacing the files and running "mach run" should be sufficient, right?), but sadly it didn't help with bug 1810874. The behavior with apz.disable_for_scroll_linked_effects=True is still the same.

Comment 4

[maciek4231]

(In reply to maciek4231 from comment #3)

(In reply to Hiroyuki Ikezoe (:hiro) from comment #0)

here in ClipManager::DefineScrollLayers we just use the return value of Document::HasScrollLinkedEffect, but the function doesn't check the pref value at all.

I am guessing this is one of the reasons of bug 1810874 even if the pref value is true.

I'm not entirely sure I built Firefox with those changes applied correctly (replacing the files and running "mach run" should be sufficient, right?), but sadly it didn't help with bug 1810874. The behavior with apz.disable_for_scroll_linked_effects=True is still the same.

Sorry, I mistyped, I meant „mach build” of course

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/1af6fa02884e