Closed Bug 1811403 Opened 9 days ago Closed 6 days ago

Respect "apz.disable_for_scroll_linked_effects" pref whether to set HasScrollLinkedEffect::Yes

Categories

(Core :: Panning and Zooming, defect, P3)

defect

Tracking

()

RESOLVED FIXED
111 Branch
Tracking Status
firefox111 --- fixed

People

(Reporter: hiro, Assigned: hiro)

References

Details

Attachments

(1 file)

here in ClipManager::DefineScrollLayers we just use the return value of Document::HasScrollLinkedEffect, but the function doesn't check the pref value at all.

I am guessing this is one of the reasons of bug 1810874 even if the pref value is true.

Assignee: nobody → hikezoe.birchill
Status: NEW → ASSIGNED
Pushed by hikezoe.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1af6fa02884e
Respect "apz.disable_for_scroll_linked_effects" pref whether to set HasScrollLinkedEffect flag. r=botond

(In reply to Hiroyuki Ikezoe (:hiro) from comment #0)

here in ClipManager::DefineScrollLayers we just use the return value of Document::HasScrollLinkedEffect, but the function doesn't check the pref value at all.

I am guessing this is one of the reasons of bug 1810874 even if the pref value is true.

I'm not entirely sure I built Firefox with those changes applied correctly (replacing the files and running "mach run" should be sufficient, right?), but sadly it didn't help with bug 1810874. The behavior with apz.disable_for_scroll_linked_effects=True is still the same.

(In reply to maciek4231 from comment #3)

(In reply to Hiroyuki Ikezoe (:hiro) from comment #0)

here in ClipManager::DefineScrollLayers we just use the return value of Document::HasScrollLinkedEffect, but the function doesn't check the pref value at all.

I am guessing this is one of the reasons of bug 1810874 even if the pref value is true.

I'm not entirely sure I built Firefox with those changes applied correctly (replacing the files and running "mach run" should be sufficient, right?), but sadly it didn't help with bug 1810874. The behavior with apz.disable_for_scroll_linked_effects=True is still the same.

Sorry, I mistyped, I meant „mach build” of course

Status: ASSIGNED → RESOLVED
Closed: 6 days ago
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in before you can comment on or make changes to this bug.