1811447 - Shrink size of MoveOperand and MoveOp

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P3)

Description

[Jan de Mooij [:jandem]]

While looking at Ion memory usage, I noticed we waste quite a lot of space here and we can easily shrink sizeof(MacroAssembler) from 2328 to 2072 bytes with some minor changes.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1811447 part 1 - Make MoveOperand::Kind an enum class and use uint8_t for it. r?iain!

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1811447 part 2 - Change MoveOperand::code_ from uint32_t to uint8_t. r?iain!

Register codes fit in a byte. See also AnyRegister::code_ for example.

Depends on D167359

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1811447 part 3 - Reorder MoveOp fields and use uint8_t for enum. r?iain!

Depends on D167360

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1811447 part 4 - Remove TempObject base class from LAllocation. r?iain!

Drive-by change: TempObject adds support for allocating using TempAllocator,
but this doesn't make sense for LAllocation because it's pointer-size anyway.

Depends on D167361

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad107c12bf98
part 1 - Make MoveOperand::Kind an enum class and use uint8_t for it. r=iain
https://hg.mozilla.org/integration/autoland/rev/7a8d1449528a
part 2 - Change MoveOperand::code_ from uint32_t to uint8_t. r=iain
https://hg.mozilla.org/integration/autoland/rev/e52abaf3f7e5
part 3 - Reorder MoveOp fields and use uint8_t for enum. r=iain
https://hg.mozilla.org/integration/autoland/rev/7fe6720b9f21
part 4 - Remove TempObject base class from LAllocation. r=iain

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ad107c12bf98
https://hg.mozilla.org/mozilla-central/rev/7a8d1449528a
https://hg.mozilla.org/mozilla-central/rev/e52abaf3f7e5
https://hg.mozilla.org/mozilla-central/rev/7fe6720b9f21