1811489 - [macOS] In some about: pages, modal windows get resized

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Ardelean Oana, Desktop QA [:oardelean]]

Attachment: Screen Recording 2023-01-20 at 16.21.36.mov

Notes

• This behavior can also be seen in about:logins when trying to edit credentials with a Primary Password set up.
• Please see the attachment for more details.

Found in

• Nightly 111.0a1;

Affected versions

• Nightly 111.0a1;
• Firefox 110.0b3;

Tested platforms

• Windows 10;
• Ubuntu 22;
• macOS 12, macOS 11, macOS 10.15;

Affected platforms

• macOS 12, macOS 11, macOS 10.15;

Unaffected platforms

• Windows 10;
• Ubuntu 22;

Steps to reproduce

1. Launch Firefox and go to about:profiles.
2. Create a new profile.
3. Click on the "Delete" button.

Expected result

• Modal window opens normally.

Actual result

• Modal window shifts down a few milimeters.

Regression range

• last good: 2023-01-10
• first bad: 2023-01-11
• pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2732d1fd969c6f535568e69a056031a071fce01e&tochange=01f0f5a5c206cfc0b9111f17600a40a74227f8fe
• Potentially regressed by : Bug 1809057

Comment 1

[Emilio Cobos Álvarez (:emilio)]

That bug only touched windows code so has to be the other one.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1807838

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1811489 - MacOS shows visibly the changes to layout if sizeToContent is called after AppWindow::OnChromeLoaded, r=emilio

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5529d6960828
MacOS shows visibly the changes to layout if sizeToContent is called after AppWindow::OnChromeLoaded, r=emilio

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/5529d6960828

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 9313702 [details]
Bug 1811489 - MacOS shows visibly the changes to layout if sizeToContent is called after AppWindow::OnChromeLoaded, r=emilio

Beta/Release Uplift Approval Request

• User impact if declined: Glitch when opening some dialogs on Mac.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See the first comment of the bug.

This definitely needs manual testing, since this is all about OS level painting and resizing of the windows.

• List of other uplifts needed: None
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): This code has proved to be very error prone in a way that if the ordering of the method calls isn't quite right, one may see visual glitches.
• String changes made/needed: NA
• Is Android affected?: No

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9313702 [details]
Bug 1811489 - MacOS shows visibly the changes to layout if sizeToContent is called after AppWindow::OnChromeLoaded, r=emilio

I think this is not a good candidate for uplifting as this seems a bit of an edgecase, is an S3, somewhat risky and we are already at the mid beta cycle point, thanks for suggesting it though!

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

I'd somewhat like to reconsider this for beta. We have seen the regression bugs for this code filed very quickly., and the patch is now in Nightly.

Comment 9

[Ardelean Oana, Desktop QA [:oardelean]]

Verified on Nightly 111.0a1(build ID: 20230126212606) on macOS 12 and macOS 10.15.

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9313702 [details]
Bug 1811489 - MacOS shows visibly the changes to layout if sizeToContent is called after AppWindow::OnChromeLoaded, r=emilio

OK, let's take it in beta 7.

Comment 11

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/b2c3df5393be

Comment 12

[Ardelean Oana, Desktop QA [:oardelean]]

Verified as fixed on Firefox 110.0b7(build ID: 20230129190147) on macOS 12 and macOS 10.15.