1811545 - [wdspec] Refactor tests for "stale element reference", "detached shadow root", and "no such shadow root" checks

Status: RESOLVED FIXED

(Testing :: geckodriver, task, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Over on bug 1808894 I'm updating the internal behavior of Marionette to correctly handle all the mentioned states for all commands. While doing that I noticed quite a few mistakes in the tests and especially areas that could be massively simplified.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1811545 - [wdspec] Enhance stale_element fixture for shadow root nodes.

Depends on D167541

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1811545 - [wdspec] Update test_no_such_element_from_other_frame tests for get_test_page fixture.

Depends on D167542

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1811545 - [wdspec] Improve Find Element(s) tests for unknown selector.

Depends on D167543

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1811545 - [wdspec] Update element and shadow root specific tests for existence and stale / detached state.

Depends on D167544

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1811545 - [wdspec] Remove usage of custom shadow root pages in favor of test_page fixture.

Depends on D167545

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55cec0043044
[wdspec] Enhance stale_element fixture for shadow root nodes. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/3e0178b3e0dc
[wdspec] Update test_no_such_element_from_other_frame tests for get_test_page fixture. r=webdriver-reviewers,Sasha,jdescottes
https://hg.mozilla.org/integration/autoland/rev/82dee6290057
[wdspec] Improve Find Element(s) tests for unknown selector. r=webdriver-reviewers,Sasha,jdescottes
https://hg.mozilla.org/integration/autoland/rev/41daafb5d75a
[wdspec] Update element and shadow root specific tests for existence and stale / detached state. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/7f0a872abb09
[wdspec] Remove usage of custom shadow root pages in favor of test_page fixture. r=webdriver-reviewers,jdescottes

Comment 7

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38208 for changes under testing/web-platform/tests

Comment 8

[Serban Stanca [:SerbanS]]

Backed out for landing with leftover files from a puppeteer install (under remote/test/puppeteer/packages/puppeteer-core/).

• Backout link
• Push with failures

Comment 9

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1d531994672
[wdspec] Enhance stale_element fixture for shadow root nodes. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/46c66c218e37
[wdspec] Update test_no_such_element_from_other_frame tests for get_test_page fixture. r=webdriver-reviewers,Sasha,jdescottes
https://hg.mozilla.org/integration/autoland/rev/10f659a58511
[wdspec] Improve Find Element(s) tests for unknown selector. r=webdriver-reviewers,Sasha,jdescottes
https://hg.mozilla.org/integration/autoland/rev/d84d48ee0d61
[wdspec] Update element and shadow root specific tests for existence and stale / detached state. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/7724c46f2973
[wdspec] Remove usage of custom shadow root pages in favor of test_page fixture. r=webdriver-reviewers,jdescottes

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b1d531994672
https://hg.mozilla.org/mozilla-central/rev/46c66c218e37
https://hg.mozilla.org/mozilla-central/rev/10f659a58511
https://hg.mozilla.org/mozilla-central/rev/d84d48ee0d61
https://hg.mozilla.org/mozilla-central/rev/7724c46f2973

Comment 12

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 13

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 14

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by jgraham