1811553 - [wpt-sync] Sync PR 38090 - Fix audio check in RtcRtpSender

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 38090 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38090
Details from upstream follow.

Guido Urdaneta <[e-mail]> wrote:

Fix audio check in RtcRtpSender

createEncodedAudioStreams() was incorrectly checking the presence of
video streams instead of audio streams.

Bug: 1406034
Change-Id: I1b18a28896afa8ecc639c3b999e10d93a2e9654c

Reviewed-on: https://chromium-review.googlesource.com/4184358
WPT-Export-Revision: 8dbbd4581be347b679bfd8c785558c1beb2b8b8b

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d57a944bc5cd33bf1fb5515c5ef507534f5251c

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 3 subtests

Status Summary

Firefox

OK : 2
FAIL: 9

Chrome

OK : 2
PASS: 8
FAIL: 1

Safari

OK : 2
FAIL: 9

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /webrtc-encoded-transform/RTCPeerConnection-insertable-streams-audio.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: OK)
  • Frames flow correctly using insertable streams: FAIL (Chrome: PASS, Safari: FAIL)
  • Frames flow correctly using insertable streams when receiver starts negotiation: FAIL (Chrome: PASS, Safari: FAIL)
  • RTCRtpSender.createEncodedStream() throws if not requested in PC configuration: FAIL (Chrome: PASS, Safari: FAIL)
  • RTCRtpReceiver.createEncodedStream() throws if not requested in PC configuration: FAIL (Chrome: PASS, Safari: FAIL)
  • Enqueuing the same frame twice fails: FAIL (Chrome: PASS, Safari: FAIL)
  • Creating streams twice throws: FAIL (Chrome: FAIL, Safari: FAIL)
• /webrtc-encoded-transform/RTCPeerConnection-insertable-streams-video.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: OK)
  • Frames flow correctly using insertable streams: FAIL (Chrome: PASS, Safari: FAIL)
  • Frames flow correctly using insertable streams when receiver starts negotiation: FAIL (Chrome: PASS, Safari: FAIL)
  • Creating streams twice throws: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

• /webrtc-encoded-transform/RTCPeerConnection-insertable-streams-audio.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: OK)
• /webrtc-encoded-transform/RTCPeerConnection-insertable-streams-video.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: OK)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1fc730e31793
[wpt PR 38090] - Fix audio check in RtcRtpSender, a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1fc730e31793