1811561 - Validate Glean Server Knobs integration on Desktop

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, task, P1)

Description

[Travis Long [:travis_]]

This bug is meant to track the work needed in execution of this proposal that outlines validation of the Server Knobs implementation in Desktop.

This will likely include:

• Adding a test event metric alongside an existing high-frequency event
• Defining and launching an experiment to exercise the metric and collect data
• Analysis of the data to ensure Server Knobs is working as intended.

Comment 1

[Travis Long [:travis_]]

Attachment: Data Review Request

Comment 2

[Travis Long [:travis_]]

Attachment: Bug 1811561 - Add a test Glean event to validate the Server Knobs functionality. r=chutten

Comment 3

[Chris H-C :chutten]

Comment on attachment 9315431 [details]
Data Review Request

PRELIMINARY NOTES:
Have you heard of ./mach data-review? It provides a template data review request with a few fields already filled in for you 1.

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in Firefox 112.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6298c18b6129
Add a test Glean event to validate the Server Knobs functionality. r=chutten

Comment 5

[Cristina Horotan [:chorotan]]

Backed out changeset 6298c18b6129 (bug 1811561) for causing node failures

Backout: https://hg.mozilla.org/integration/autoland/rev/e2e5d8ac8c43c378e34f47aa102a8d979ebbcf32

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=P6L_FF86R9m5V83bWvQAFA.0&revision=6298c18b6129c7a9640d4e2f88883915f9862690

Failure log: https://treeherder.mozilla.org/logviewer?job_id=404351666&repo=autoland&lineNumber=261

Comment 6

[Travis Long [:travis_]]

Ooof, I've just learned that there are some npm tests that aren't ran as part of mach test. Fixing this up before resubmitting.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a4ba669dd0b
Add a test Glean event to validate the Server Knobs functionality. r=chutten

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/5a4ba669dd0b

Comment 9

[Travis Long [:travis_]]

Cross linking to make this easier to find in the future https://mozilla-hub.atlassian.net/browse/DS-2689