1811575 - swipe-to-nav icon may reappear shortly after the gesture is cancelled

Status: VERIFIED FIXED

(Core :: Panning and Zooming, defect, P2)

Description

[Dan Robertson (:dlrobertson)]

Summary

After "cancelling" a swipe to navigate gesture, the icon may reappear shortly along with the icon on the opposite side.

Steps to Reproduce

Steps

0. Optional: This is much easier to see in dark mode. For example, I use the dark default github theme
1. Navigate to https://bugzilla.mozilla.org, to get some history
2. Use the same tab to navigate to https://github.com
3. Use the same tab to navigate to a third page like https://planet.mozilla.org
4. Navigate back to the page loaded in step 2
5. Start a back swipe to navigate gesture, but do not "complete" the gesture. Instead cancel the gesture with a gesture to the opposite side.

Expected Results

The cancel animation runs and when the animation finishes it does not reappear.

Actual Results

The cancel animation for the backwards swipe to navigate gesture runs, and the momentum pan causes the forwards animation to run. When the forwards animation completes, the backwards icon reappears for a second.

Note: this is much easier to see if the "cancel" gesture is done with much gusto.

Comment 1

[Dan Robertson (:dlrobertson)]

Attachment: s2n-icon-reappear.gif

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1799563

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Thank you Dan for filing/finding this bug! This happens because we show the icon even if the given aVal == 0. The reason why we didn't hit this issue before bug 1799563 is that probably before bug 1799563 the icon was rendered as opacity: 0 initially so that we hadn't noticed this issue at all.

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1811575 - Make sure the swipe-to-navigation icon isn't rendered at zero progress gesture value. r?tnikkel

Comment 5

[Dan Robertson (:dlrobertson)]

Thanks for the quick patch!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c620038ec24f
Make sure the swipe-to-navigation icon isn't rendered at zero progress gesture value. r=tnikkel

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c620038ec24f

Comment 10

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2023-01-20 Nightly build on macOS 12.
Verified as fixed on Firefox 111.0b5(build ID: 20230223185944) and Nightly 112.0a1(build ID: 20230223172038) on macOS 12, Windows 10, Ubuntu 22.