1811687 - Reconsider the color used for the new swipe indicator in dark mode

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Description

[matthias koplenig [:metasieben]]

The new swipe-gesture-indicator is hardcoded to always be blue (#0060DF), shouldn't there be a different color if the user is in dark mode?

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Panning and Zooming' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:hiro, since you are the author of the regressor, bug 1799563, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Why do you think it's regression? As far as I can tell it was originally hard coded. Redirecting NI to Josh.

Comment 4

[matthias koplenig [:metasieben]]

Sorry :hiro for tagging as regression, should have been a simple follow-up.

While the color of the old indicator was also hardcoded, it was a much more "neutral" dark gray.
The spec svg in bug 1799563 mentions Windows/Mac in Normal and HCM mode, however making no differentiation
whether the user is in light/dark mode.

Comment 5

[Josh Berman]

Hi there,

Please see the linked artboard which shows default primary color scheme in comparison with dark mode color scheme. Included an example of it's application to the Windows UI component.

https://www.figma.com/file/c7sOMnzf8NzcQTLRc8HmLs/Swipe-to-Navigate-Windows?node-id=725%3A5972&t=hL8DVgOvDWKmlYGa-1

Thank you,

Comment 6

[matthias koplenig [:metasieben]]

Hey Josh, thanks for the info, but Figma boards are sadly only accessible to employees.

Comment 7

[Josh Berman]

Attachment: Screen Shot 2023-01-24 at 11.57.16 AM.png

Ahh apologies. Default vs Dark - screenshot attached. Hex codes below.

Primary
Default - 0060DF
Dark - 00DDFF

Accent
Default - FFFFFF
Dark - 000000

Comment 8

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1811687 - Support dark mode friendly swipe-to-navigation icon colors. r?#desktop-theme-reviewers

Comment 9

[Hiroyuki Ikezoe (:hiro)]

Thank you Josh for uploading the image!

Though I've uploaded D167762 which has the new colors for dark mode, it does just respect the system global setting, it doesn't respect Firefox's "Website appearance" preference because I don't know the way to tell the difference. I will ask it in Matrix.

Comment 10

[Hiroyuki Ikezoe (:hiro)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #9)

Though I've uploaded D167762 which has the new colors for dark mode, it does just respect the system global setting, it doesn't respect Firefox's "Website appearance" preference because I don't know the way to tell the difference. I will ask it in Matrix.

Itiel told me -moz-content-prefers-color-scheme.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64f3410eeb38
Support dark mode friendly swipe-to-navigation icon colors. r=desktop-theme-reviewers,Itiel

Comment 12

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/64f3410eeb38