1811804 - GeckoJavaSampler::StopProfiler doesn't stop the profiler

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect, P1)

Description

[Florian Quèze [:florian]]

Using the profiler directly within Fenix with the instructions at https://profiler.firefox.com/docs/#/./guide-profiling-android-directly-on-device?id=profiling-firefox-for-android-directly-on-device leaves the SamplerThreads running after capturing the profile.

Profiling on Fenix using remote profiling doesn't leave the profiler running.

Nazim looked into it and wrote on Matrix:

fenix profiling calls this function and this C++ function gets called with JNI. If you look at that function we pause the profiler and then capture the data but don't stop it in the end.

Comment 1

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1811804 - Stop the profiler after capturing a profile on an Android device r?mstange,florian

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0565816c9303
Stop the profiler after capturing a profile on an Android device r=mstange

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0565816c9303