1811853 - Clean up the javascript code

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), task, P2)

Description

[Julien Wajsberg [:julienw]]

In this bug we want to do the following work:

• reorder the existing code so that it's easier to follow
• merge the shared gecko-profiler-interface.js into the actor
• possibly some other few small passing-by changes

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: Bug 1811853 - Slightly simplify recording-utils to make the function easier to read r=canaltinova

Comment 2

[Julien Wajsberg [:julienw]]

Attachment: Bug 1811853 - Merge gecko-profiler-interface.js into the perf actor r=jdescottes!,canaltinova!

Depends on D167842

Comment 3

[Julien Wajsberg [:julienw]]

Attachment: Bug 1811853 - Move background.jsm.js to a shared subdirectory r=canaltinova

Depends on D167844

Comment 4

[Julien Wajsberg [:julienw]]

Attachment: Bug 1811853 - Move symbolication files to the shared/ directory r=canaltinova

Depends on D167845

Comment 5

[Julien Wajsberg [:julienw]]

Attachment: Bug 1811853 - Move utilities files to shared/ r=canaltinova

Depends on D167846

Comment 6

[Julien Wajsberg [:julienw]]

Attachment: Bug 1811853 - Move the performance panel's browser component to the shared/ directory r=canaltinova

Depends on D167847

Comment 7

[Julien Wajsberg [:julienw]]

Attachment: Bug 1811853 - Rename panel.jsm.js to logic.jsm.js, to better reflect its content r=canaltinova

Depends on D167848

Comment 8

[Julien Wajsberg [:julienw]]

Attachment: Bug 1811853 - Move the panel related files to a new subdirectory panel/ r=canaltinova

Depends on D167849

Comment 9

[Julien Wajsberg [:julienw]]

Attachment: Bug 1811853 - Update the README file for the performance devtools panel r=canaltinova

Depends on D167850

Comment 10

[Julien Wajsberg [:julienw]]

Attachment: Bug 1811853 - Reorder the performance panel's components directory between components for about:profiling and the ones for the devtools panel r=canaltinova

Depends on D167851

Comment 11

[Julien Wajsberg [:julienw]]

Try is https://treeherder.mozilla.org/jobs?repo=try&revision=5e9f547d27b127aaa199030753194ea608e882ac and green!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6be5deab81f5
Slightly simplify recording-utils to make the function easier to read r=canaltinova
https://hg.mozilla.org/integration/autoland/rev/ecab2148d597
Merge gecko-profiler-interface.js into the perf actor r=jdescottes,canaltinova
https://hg.mozilla.org/integration/autoland/rev/3451927cc040
Move background.jsm.js to a shared subdirectory r=canaltinova
https://hg.mozilla.org/integration/autoland/rev/23c02bc5eec3
Move symbolication files to the shared/ directory r=canaltinova
https://hg.mozilla.org/integration/autoland/rev/66d30d3f61d1
Move utilities files to shared/ r=canaltinova
https://hg.mozilla.org/integration/autoland/rev/570647c99cd0
Move the performance panel's browser component to the shared/ directory r=canaltinova
https://hg.mozilla.org/integration/autoland/rev/19521820748e
Rename panel.jsm.js to logic.jsm.js, to better reflect its content r=canaltinova
https://hg.mozilla.org/integration/autoland/rev/7f2a55352dfc
Move the panel related files to a new subdirectory panel/ r=canaltinova
https://hg.mozilla.org/integration/autoland/rev/6c1721630a15
Update the README file for the performance devtools panel r=canaltinova
https://hg.mozilla.org/integration/autoland/rev/499bdfd543e9
Reorder the performance panel's components directory between components for about:profiling and the ones for the devtools panel r=canaltinova

Comment 13

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/6be5deab81f5
https://hg.mozilla.org/mozilla-central/rev/ecab2148d597
https://hg.mozilla.org/mozilla-central/rev/3451927cc040
https://hg.mozilla.org/mozilla-central/rev/23c02bc5eec3
https://hg.mozilla.org/mozilla-central/rev/66d30d3f61d1
https://hg.mozilla.org/mozilla-central/rev/570647c99cd0
https://hg.mozilla.org/mozilla-central/rev/19521820748e
https://hg.mozilla.org/mozilla-central/rev/7f2a55352dfc
https://hg.mozilla.org/mozilla-central/rev/6c1721630a15
https://hg.mozilla.org/mozilla-central/rev/499bdfd543e9