1811871 - Regression: New blue Forward indicator disappears with delay

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Mehmet]

Attachment: demo.mov

Nightly 111.0a1 (2023-01-23) (64-Bit)
macOS 12.6.2

1.) Open a new Tab
2.) Visit a page in that tab
3.) Swipe back with the Trackpad to the previous page
4.) Swipe forward to the other page again

Actual: The new forward indicator disappears with delay. This isn't the case for the back indicator.

Expected: The forward indicator should also disappear quickly.

This seems to be a regression, since using the new blue back/forward indicators in Nightly.

A demo of the issue is attached.

Comment 1

[Mehmet]

Mozregression brings me to bug 1799563.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1799563

:hiro, since you are the author of the regressor, bug 1799563, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

This is due to these opacity value checks. We basically no longer change the opacity value so that we should check other things we change, probably collapsed attribute. That said, I suspect bug 1811792 is caused by the same root cause, maybe we should also change opacity style value, just setting to 0 or 1?

Comment 4

[Hiroyuki Ikezoe (:hiro)]

I can't reproduce bug 1811792 locally both on Linux and Mac, so I am going to fix this bug by checking collapsed attribute value here.

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1811871 - Check collapsed attribute rather than computed opacity value to tell whether which navigation ison is currently visible. r?tnikkel

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Note that the delay-ed fade out is intentional, the backward non-delayed disappearing is unintentional.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e84a4ebcc3d
Check collapsed attribute rather than computed opacity value to tell whether which navigation ison is currently visible. r=tnikkel

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/2e84a4ebcc3d

Comment 9

[Mehmet]

Thanks for fixing this issue. Works fine in Nightly 111.0a1 (2023-01-26) (64-Bit) on macOS.

Comment 10

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproduced on a 2023-01-23 Nightly build on macOS 12.
Verified as fixed on Firefox 111.0b3(build ID: 20230219190218) and Nightly 112.0a1(build ID: 20230221052246) on macOS 12, Windows 11, Ubuntu 22.