1811953 - Screenshots component should scroll when moving box along the edge

Status: RESOLVED FIXED

(Firefox :: Screenshots, defect, P3)

Description

[Niklas Baumgardner [:niklas]]

The extension can scroll when resizing along the edge. The component should match

Comment 1

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1811953 - Scroll when resizing near the edge. r=sfoster

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13175567352f
Scroll when resizing near the edge. r=sfoster

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on browser_screenshots_drag_scroll_test.js

• backout: https://hg.mozilla.org/integration/autoland/rev/5bab40038c445b229a458cb9d6a2776db7a30602
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=LMDW1MLeT1qkBHyULozn2w.0&revision=13175567352fb075c2fa8396e60cafd9ca526b2d
• failure log: https://treeherder.mozilla.org/logviewer?job_id=403637816&repo=autoland&lineNumber=15036

[task 2023-01-26T17:09:33.997Z] 17:09:33     INFO - TEST-UNEXPECTED-FAIL | browser/components/screenshots/tests/browser/browser_screenshots_drag_scroll_test.js | Window x position is 1000 - Got 980, expected 1000
[task 2023-01-26T17:09:33.997Z] 17:09:33     INFO - Stack trace:
[task 2023-01-26T17:09:33.997Z] 17:09:33     INFO - chrome://mochikit/content/browser-test.js:test_is:1484
[task 2023-01-26T17:09:33.997Z] 17:09:33     INFO - chrome://mochitests/content/browser/browser/components/screenshots/tests/browser/browser_screenshots_drag_scroll_test.js:test_scrollIfByEdge/<:382
[task 2023-01-26T17:09:33.998Z] 17:09:33     INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-01-26T17:09:33.999Z] 17:09:33     INFO - TEST-UNEXPECTED-FAIL | browser/components/screenshots/tests/browser/browser_screenshots_drag_scroll_test.js | Window y position is 1000 - Got 980, expected 1000
[task 2023-01-26T17:09:34.000Z] 17:09:33     INFO - Stack trace:
[task 2023-01-26T17:09:34.000Z] 17:09:33     INFO - chrome://mochikit/content/browser-test.js:test_is:1484
[task 2023-01-26T17:09:34.000Z] 17:09:33     INFO - chrome://mochitests/content/browser/browser/components/screenshots/tests/browser/browser_screenshots_drag_scroll_test.js:test_scrollIfByEdge/<:383
[task 2023-01-26T17:09:34.001Z] 17:09:34     INFO - GECKO(9034) | [Child 9342, Main Thread] WARNING: GetClosestNativeAnonymousSubtreeRoot on disconnected NAC!: file /builds/worker/workspace/obj-build/

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:niklas, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16ba3804995a
Scroll when resizing near the edge. r=sfoster

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/16ba3804995a