1811963 - CustomElementData::Traverse should use NoteXPCOMChild for mElementInternals

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Andrew McCreight [:mccr8]]

CustomElementData::Traverse uses NoteNativeChild for mElementInternals, which has type ElementInternals. However, ElementInternals is an nsISupports class, so this should use NoteXPCOMChild instead. I don't think this is an issue now, but it could cause problems if ElementInternals had any subclasses with their own CC participant. I audited all of the other direct calls to NoteNativeChild (there aren't a lot because most things go through the template magic that picks the right one) and the rest were all for non-nsISupports classes, as is appropriate.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1811963 - CustomElementData::Traverse should use NoteXPCOMChild for mElementInternals.

ElementInternals is an nsISupports class, so this should use NoteXPCOMChild.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a48f2317a143
CustomElementData::Traverse should use NoteXPCOMChild for mElementInternals. r=smaug

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/a48f2317a143