1811976 - Sync button shows up when logged out in the Tab view

Status: RESOLVED FIXED

(Firefox for Android :: Accounts and Sync, defect, P2)

Description

[Vlad Filippov (:vladikoff)]

Attachment: Screenshot_20230123-204203.png

Steps to reproduce

1. Fresh install of Firefox for Android
2. Open the New Tab screen

Expected behavior

Sync button should not show up when logged out

Actual behavior

Sync button shows up, pressing it shows indefinite Syncing... indicator

Device information

• Firefox version:

109.1.1 (Build #2015927171), 8f4899e33+
AC: 109.1.1, 1dd31ba60c
GV: 109.0-20230112150232
AS: 96.1.3

• Android device model: Pixel 6
• Android OS version: 13

Any additional information?

See screenshot

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:cpeterson, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

huh - this is still true, and if you press the button, it changes to "Syncing" and stays there forever!

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:royang, could you have a look please?

For more information, please visit BugBot documentation.

Comment 4

[Vlad Dreghici [:vdreghici]]

I could not find any documents regarding how this button should be displayed. It seems like this bug was present in the xml version as well. I have a patch that removes it in the tabs sync page when there is no user signed in, but I would still like to confirm with UX that this is indeed the expected behavior.

Comment 5

[Mark Hammond [:markh] [:mhammond]]

The "Sign in to Sync" button should be visible, the "Sync" button should be hidden.

Comment 6

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1811976 - Hide Sync FAB in TabsTray when user not signed in (#3732)

Comment 7

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1811976 - Hide Sync FAB in TabsTray when user not signed in (#3758)

Comment 8

[BMO Github Automation]

Authored by https://github.com/DreVla
https://github.com/mozilla-mobile/firefox-android/commit/eac1a280dce796dc0c8f9f4d5329fe0b8f925c65
[main] Bug 1811976 - Hide Sync FAB in TabsTray when user not signed in

Comment 9

[Lorand Janos]

Managed to reproduce this issue on an earlier Nightly build (119.0a1 from 2023-09-22).
Verified as fixed on the latest Nightly build (119.0a1 from 2023-09-25).
Device used: Samsung Galaxy S23 Ultra (Android 13).
Marking the ticket as verified on 119.

Comment 10

[Lorand Janos]

Attachment: Before (2).jpg

Comment 11

[Lorand Janos]

Attachment: After (2).jpg