1812025 - The java threads are sampled even when the nostacksampling feature is used to reduce overhead

Status: NEW

(Core :: Gecko Profiler, defect, P2)

Description

[Florian Quèze [:florian]]

Example profile: https://share.firefox.dev/3HrogXH

Comment 1

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

This is where we start the java profiler: https://searchfox.org/mozilla-central/rev/cf3af6bb6657278880f8baf38435eeb8f2d5d86c/tools/profiler/core/platform.cpp#5821-5843
which calls this function on the Java side:
https://searchfox.org/mozilla-central/rev/cf3af6bb6657278880f8baf38435eeb8f2d5d86c/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoJavaSampler.java#569-570
We should pass the ProfilerFeature::HasNoStackSampling(features) there and start the sampler depending on that.

Note that even though name of the class says GeckoJavaSampler it's also used to start the marker collection (welp). That's why it's not enough to not call that function, we should handle it inside the java side instead.