Closed Bug 1812047 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 38138 - Don't attempt to calculate block-size if inline-size is indefinite.

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
111 Branch
Tracking Status
firefox111 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 38138 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38138
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

Don't attempt to calculate block-size if inline-size is indefinite.

During block fragmentation, while inside the constructor of
NGLayoutAlgorithm, we attempt to resolve the block-size (to see if it's
definitely going to fit inside the fragmentainer). This only makes sense
when actually performing layout, and not when calculating intrinsic
min-max inline sizes, but at this point, we have no means of figuring
out what's going to happen next.

Rather than requiring every algorithm to hook up with the fragmentation
machinery in their Layout() override, keep it as it is, but skip the
block-size calculation part if inline-size is indefinite.

Bug: 1409822
Change-Id: Ie9bf5ec7f2a3cd03ed1a468aa3c5369b26ad1fc1
Reviewed-on: https://chromium-review.googlesource.com/4188885
WPT-Export-Revision: 446d74c8d47e03d46dbb9d8af8a2e8f36a8a2a8c

Component: web-platform-tests → Layout
Product: Testing → Core
Test result changes from PR not available.
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/93255637140d [wpt PR 38138] - Don't attempt to calculate block-size if inline-size is indefinite., a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in before you can comment on or make changes to this bug.