1812149 - LocaleAwareAppCompatActivity should use a ContextWrapper to update the locale instead

Status: RESOLVED FIXED

(Firefox for Android :: General, enhancement, P1)

Description

[Jonathan Almeida [:jonalmeida]]

There are times when we need to use the original Context and not the updated context after a configuration change.

We've seen this recently with the removal of the deprecated APIs in Resources.updateConfiguration() which no longer update the existing Context, but instead provide a new Activity Context via Context.createConfigurationContext.

When looking at how the new window.print GeckoView API will work in our Android Components code, the Context provided to us from the LocaleAwareAppCompatActivity throws an IllegalStateException on the context type.

Other users have also faced this issue as well with the removal of the deprecated API.

What we should do, is use a ContextWrapper that is meant for this purpose, provide some changes and delegate the rest to the default implementation, and also giving us access to the original context that we would need with the PrintManager via ContextWrapper.getBaseContext().

Comment 1

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1812149 - Add ContextWrapper before updating locale (#1020)

Comment 2

[Jonathan Almeida [:jonalmeida]]

This work is done in 112, but we are landing it in 113 since it's late in the release cycle.

Comment 3

[BMO Github Automation]

Authored by https://github.com/jonalmeida
https://github.com/mozilla-mobile/firefox-android/commit/c6b6a13ba53771ab23f38df967b694c4748d83db
[main] Bug 1812149 - Add ActivityContextWrapper before updating locale

Comment 4

[Chris Peterson [:cpeterson]]

(In reply to Jonathan Almeida [:jonalmeida] from comment #2)

This work is done in 112, but we are landing it in 113 since it's late in the release cycle.

Jonathan, should we uplift your fix to Beta 112? Will users experience problems in 112 if this fix ships in 113?

Comment 5

[Jonathan Almeida [:jonalmeida]]

No, this patch is only useful with ohall's window.print changes. So uplifting this will have no value to users as the window.print patch has to ride the trains.