1812195 - Add alipay.com and miravia.es to the site permission blocklist

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement)

Description

[Bobby Holley (:bholley)]

Bug 1806056, which allows users to report sites that spuriously request MIDI access, shipped in Firefox 109. Telemetry shows the prompt rate dropping by about 85% just before 109 was released (primarily in US and Canada), which suggests there was one whale of a culprit which changed its behavior just before we gained the capability to identify it. So we may never know who it was.

However, we still received a handful of reports for other sites, which we should add to our blocklist to drive the remaining ~3000 daily prompts closer to zero.

Comment 1

[Bobby Holley (:bholley)]

Attachment: Bug 1812195 — Add alipay.com and miravia.es to the site permission blocklist.

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1812195 - Make sure test_sitePermsAddonProvider.js covers multiple comma separated domains set on the site permission blocklist pref. r?bholley!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6b008187626
— Add alipay.com and miravia.es to the site permission blocklist. r=rpl

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10fa979679d2
Make sure test_sitePermsAddonProvider.js covers multiple comma separated domains set on the site permission blocklist pref. r=bholley

Comment 5

[Bobby Holley (:bholley)]

Comment on attachment 9313899 [details]
Bug 1812195 — Add alipay.com and miravia.es to the site permission blocklist.

Beta/Release Uplift Approval Request

• User impact if declined: Nuisance prompts for another cycle.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very low risk. Just adds some site we've identified as using WebMIDI in bad faith to an existing blocklist that prevents them from doing so.
• String changes made/needed: None
• Is Android affected?: No

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d6b008187626
https://hg.mozilla.org/mozilla-central/rev/10fa979679d2

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9313899 [details]
Bug 1812195 — Add alipay.com and miravia.es to the site permission blocklist.

Approved for 110 beta 6, thanks.

Comment 8

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/ac46f9e5a70f
https://hg.mozilla.org/releases/mozilla-beta/rev/c5285f2b1a72