1812260 - Building a snap from source fails for 111, build errors in angle

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[Kestrel]

The Nightly snap package on the edge channel is currently stuck on version 111.0a1 (2023-01-20).

Output of snap info firefox:

latest/edge:      111.0a1      2023-01-20 (2293) 196MB

Comment 1

[Mike Kaply [:mkaply]]

We have a build break in gfx/angle I'm going to morph this bug to that.

The snap nightly builds have been failing for a few days.
Looking at the build logs, I see errors like

/root/parts/firefox/build/gfx/angle/checkout/src/compiler/translator/SymbolTable_ESSL_autogen.cpp:4337:50: error: no member named 'isnan' in namespace 'sh::BuiltInName'
BuiltInName::isnan,
~~~~~~~~~~~~~^

This is the same as bug 1727087

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:egubler, since you are the author of the regressor, bug 1753349, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 3

[Erich Gubler [:ErichDonGubler]]

For reference, it appears that :mkaply is referring to build logs like from https://github.com/canonical/firefox-snap/actions/runs/4006192421/jobs/6877431037.

I currently have a patch in open review for this, and am trying to validate the fix locally.

Comment 4

[Erich Gubler [:ErichDonGubler]]

Attachment: Bug 1812260: build(snap): re-apply forgotten `cmath` include in ANGLE codegen (sorry!) r=jgilbert,#gfx-reviewers

Re-apply D156577, which was forgotten in our recent rebase of ANGLE (orig. performed at 06d250c819ee
and 94699211d97b).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55bf697eb447
build(snap): re-apply forgotten `cmath` include in ANGLE codegen (sorry!) r=jgilbert,gfx-reviewers,nical

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/55bf697eb447

Comment 7

[Erich Gubler [:ErichDonGubler]]

I can confirm that the nightly snap build seems to be fixed. 🙌🏻