1812341 - 3D transforms are broken on https://youriguide.com/1505_sesame_st_toronto_on

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

The images are supposed to move around as if they are in a cube. They do something weird instead.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: A reduced test case

The rendering of this file is quite different in Chrome/Safari vs Firefox.
Removing backface-visibility: hidden; makes the rendering in Firefox match Chrome/Safari

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=dab17001496e9c081e75f64a8a88783c89e23a24&tochange=5b893577aa19cba4736158327e6e2465bd9044c8

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1772049

:gw, since you are the author of the regressor, bug 1772049, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 4

[Glenn Watson [:gw]]

Attachment: Bug 1812341 - Fix 3d transforms bug with backface-visibility: hidden

Revert the original changes from bug 1772049 for now. We don't
currently rely on that patch, having found a simpler way to
handle how that code interacts with the backdrop-filter code.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba052559668b
Fix 3d transforms bug with backface-visibility: hidden r=gfx-reviewers,jrmuizel

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/ba052559668b

Comment 7

[Pascal Chevrel:pascalc]

Would that be a safe uplift in our last 110 betas this week? Thanks

Comment 8

[Glenn Watson [:gw]]

Hi Pascal, it should be a safe change to land - it's a small patch and is a revert of a previous patch. It will also need the patch I just attached to https://bugzilla.mozilla.org/show_bug.cgi?id=1813514 though, I guess, to add a little fuzziness to the new reftest. Shall I go ahead and request uplift of both of these?

Comment 9

[Pascal Chevrel:pascalc]

(In reply to Glenn Watson [:gw] from comment #8)

Hi Pascal, it should be a safe change to land - it's a small patch and is a revert of a previous patch. It will also need the patch I just attached to https://bugzilla.mozilla.org/show_bug.cgi?id=1813514 though, I guess, to add a little fuzziness to the new reftest. Shall I go ahead and request uplift of both of these?

Please do, thanks!

Comment 10

[Glenn Watson [:gw]]

Comment on attachment 9314393 [details]
Bug 1812341 - Fix 3d transforms bug with backface-visibility: hidden

Beta/Release Uplift Approval Request

• User impact if declined: Fixes a webcompat visual bug
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1813514
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's a revert of an optimization, and a small patch.
• String changes made/needed:
• Is Android affected?: Yes

Comment 12

[Pascal Chevrel:pascalc]

Comment on attachment 9314393 [details]
Bug 1812341 - Fix 3d transforms bug with backface-visibility: hidden

Approved for our last 110 beta, thanks.

Comment 13

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/51266ac9b017

Comment 14

[Gabi Cheta [:Gabi] Desktop QA]

Reproduce the issue with Firefox 110.0b8 on Windows 10x64.
Verified as fixed with Firefox 110.0b9 and Firefox Nightly 111.0a1 on Windows 10x64, Ubuntu 18.4 and macOS 10.12.6.