Closed Bug 1812348 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 38171 - wake lock: Move tests in web_tests/wake-lock to either wpt_internal or external/wpt.

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox111 fixed)

Status:
RESOLVED FIXED
Milestone:
111 Branch
Tracking Flags:
Tracking Status
firefox111 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 38171 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38171
Details from upstream follow.

Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> wrote:

wake lock: Move tests in web_tests/wake-lock to either wpt_internal or external/wpt.

We had Wake Lock-related tests in 3 different directories:
external/wpt/screen-wake-lock/, wake-lock/, and
wpt_internal/system-wake-lock.

Get rid of the wake-lock/ directory by moving the tests in it to the
other two directories:

  • wakelock-document-hidden.https.html: Move it to WPT. It was not there
    because it depended on setMainWindowHidden(). WPT has since added
    support for controlling page visibility via
    test_driver.minimize_window() and test_driver.set_window_rect(), so we
    can use them via window_state_context().
    While here, merge some bits and pieces from WPT's
    wakelock-document-hidden-manual.https.html and remove the manual test,
    both tests were essentially testing the same thing.
  • wakelockpermissiondescriptor.https.html: Move to
    wpt_internal/system-wake-lock/, as it was just checking if a system
    wake lock has a proper permission descriptor. While at it, turn it
    into a .js test to make it shorter.

Change-Id: I4a524c1fcafbb44c4a063ede81e616a60115a0db
Reviewed-on: https://chromium-review.googlesource.com/4194594
WPT-Export-Revision: cb403b2e183b69d1d313a45d4b56757bf3020451

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

OK : 1
FAIL: 2

Chrome

OK : 1
PASS: 2

Safari

OK : 1
FAIL: 2

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b096fce57b7e [wpt PR 38171] - wake lock: Move tests in web_tests/wake-lock to either wpt_internal or external/wpt., a=testonly https://hg.mozilla.org/integration/autoland/rev/982b53e1105b [wpt PR 38171] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/b096fce57b7e
https://hg.mozilla.org/mozilla-central/rev/982b53e1105b

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox111: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in before you can comment on or make changes to this bug.