1812353 - WebGPU: standard features and limits not yet conforming to spec.

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, defect, P1)

Description

[Erich Gubler [:ErichDonGubler]]

Original context: https://matrix.to/#/!AQDMTeppDxxlzBSBzM:mozilla.org/$poNMnPNfzQHeJN4AwivuLMs1zBI3cx6i_Hokkdn6N2I?via=mozilla.org&via=matrix.org

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jimb, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Erich Gubler [:ErichDonGubler]]

Attachment: image.png

Comment 3

[Erich Gubler [:ErichDonGubler]]

Attachment: image.png

Comment 4

[Erich Gubler [:ErichDonGubler]]

https://searchfox.org/mozilla-central/source/dom/webgpu/Adapter.cpp

Comment 5

[Kelsey Gilbert [:jgilbert]]

I wish I had known this was important, I would have done it 27 days ago! :)
If this is important, this should not be P3, it should be P1.

Comment 7

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1812353 - Update GPUSupportedLimits in webgpu.webidl.

• Add validation for requested features and devices for
  adapter.requestDevice().
• Promote webgl's AutoAssertCast to mfbt/Casting.h/LazyAssertedCast.

Comment 8

[Jim Blandy :jimb]

(In reply to Kelsey Gilbert [:jgilbert] from comment #5)

I wish I had known this was important, I would have done it 27 days ago! :)
If this is important, this should not be P3, it should be P1.

Yes - this was my bad.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8352bc23343d
Update GPUSupportedLimits in webgpu.webidl. r=webgpu-reviewers,webidl,saschanaz,jimb,emilio,smaug

Comment 10

[Serban Stanca [:SerbanS]]

Backed out for causing causing build bustages in Adapter.cpp.

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/dom/webgpu/Adapter.cpp:152:18: error: unused variable 'featureStr' [-Werror,-Wunused-variable]

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ed1439037c4
Update GPUSupportedLimits in webgpu.webidl. r=webgpu-reviewers,webidl,saschanaz,jimb,emilio,smaug

Comment 12

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/5ed1439037c4